Skip to content

Commit 5e79fea

Browse files
authored
Merge pull request #633 from ethereum/node.js-18
Switch away from deprecated `circleci/node` images and update node.js in CI to 18
2 parents c730618 + f0ef2f5 commit 5e79fea

File tree

1 file changed

+18
-20
lines changed

1 file changed

+18
-20
lines changed

.circleci/config.yml

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ workflows:
77
- node-v14
88
- node-v16:
99
run_coveralls: true
10-
- node-v17
10+
- node-v18
1111
- hardhat-core-default-solc
1212
- hardhat-core-latest-solc
1313
- hardhat-sample-project
@@ -29,7 +29,7 @@ commands:
2929
- run:
3030
name: Update globally available npm to the latest version
3131
# Note: We need npm >= 8.3 which supports 'overrides' in package.json
32-
command: sudo npm install npm --global
32+
command: npm install npm --global
3333

3434
install-dependencies:
3535
parameters:
@@ -155,7 +155,7 @@ jobs:
155155
node-base: &node-base
156156
working_directory: ~/solc-js
157157
docker:
158-
- image: circleci/node
158+
- image: cimg/node:current
159159
parameters:
160160
run_coveralls:
161161
type: boolean
@@ -184,9 +184,8 @@ jobs:
184184

185185
hardhat-core-default-solc:
186186
docker:
187-
- image: circleci/node:16
187+
- image: cimg/node:16.15
188188
steps:
189-
- update-npm
190189
- show-npm-version
191190
- provision-and-package-solcjs
192191
- provision-hardhat-with-packaged-solcjs
@@ -212,9 +211,8 @@ jobs:
212211
213212
hardhat-core-latest-solc:
214213
docker:
215-
- image: circleci/node:16
214+
- image: cimg/node:16.15
216215
steps:
217-
- update-npm
218216
- show-npm-version
219217
- provision-and-package-solcjs
220218
- provision-hardhat-with-packaged-solcjs
@@ -230,9 +228,8 @@ jobs:
230228
231229
hardhat-sample-project:
232230
docker:
233-
- image: circleci/node:16
231+
- image: cimg/node:16.15
234232
steps:
235-
- update-npm
236233
- show-npm-version
237234
- provision-and-package-solcjs
238235
- run: git clone --depth 1 "https://github.com/nomiclabs/hardhat-hackathon-boilerplate" boilerplate/
@@ -284,11 +281,13 @@ jobs:
284281
285282
truffle-sample-project:
286283
docker:
287-
- image: circleci/node:16
284+
- image: cimg/node:16.15
288285
steps:
289286
- update-npm
290287
- show-npm-version
291288
- provision-and-package-solcjs
289+
- run: sudo apt update
290+
- run: sudo apt install python3 python-is-python3 --assume-yes --no-install-recommends
292291
- provision-truffle-with-packaged-solcjs
293292
- run:
294293
name: Unbox MetaCoin
@@ -309,15 +308,14 @@ jobs:
309308
command: |
310309
cd metacoin/
311310
# `truffle test` compiles the project but artifacts go into /tmp/
312-
! [[ -e build/ ]] || false
313-
echo "module.exports['compilers'] = {solc: {version: '$(realpath node_modules/solc/)'}}" > truffle-config.js
311+
! [[ -e build/ ]]
312+
echo "module.exports['compilers'] = {solc: {version: '$(realpath ../truffle/node_modules/solc/)'}}" >> truffle-config.js
314313
node ../truffle/node_modules/.bin/truffle test
315314
316315
cli-smoke-test:
317316
docker:
318-
- image: circleci/node:17
317+
- image: cimg/node:current
319318
steps:
320-
- update-npm
321319
- show-npm-version
322320
- provision-and-package-solcjs
323321
- run:
@@ -356,20 +354,20 @@ jobs:
356354
node-v10:
357355
<<: *node-base
358356
docker:
359-
- image: circleci/node:10
357+
- image: cimg/node:10.24
360358
node-v12:
361359
<<: *node-base
362360
docker:
363-
- image: circleci/node:12
361+
- image: cimg/node:12.22
364362
node-v14:
365363
<<: *node-base
366364
docker:
367-
- image: circleci/node:14
365+
- image: cimg/node:14.19
368366
node-v16:
369367
<<: *node-base
370368
docker:
371-
- image: circleci/node:16
372-
node-v17:
369+
- image: cimg/node:16.15
370+
node-v18:
373371
<<: *node-base
374372
docker:
375-
- image: circleci/node:17
373+
- image: cimg/node:18.3

0 commit comments

Comments
 (0)