Add safeguard in compileStandardWrapper for unlikely edge case of compile returning invalid JSON

axic · axic · commit ae091c006170 · 2018-09-27T13:37:51.000+01:00
diff --git a/wrapper.js b/wrapper.js
@@ -155,7 +155,12 @@ function setupMethods (soljson) {
     }
 
     function translateOutput (output) {
-      output = translate.translateJsonCompilerOutput(JSON.parse(output));
+      try {
+        output = JSON.parse(output);
+      } catch (e) {
+        return formatFatalError('Compiler returned invalid JSON: ' + e.message);
+      }
+      output = translate.translateJsonCompilerOutput(output);
       if (output == null) {
         return formatFatalError('Failed to process output');
       }

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,12 @@ function setupMethods (soljson) {`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`function translateOutput (output) {`
`158`		`- output = translate.translateJsonCompilerOutput(JSON.parse(output));`
	`158`	`+ try {`
	`159`	`+ output = JSON.parse(output);`
	`160`	`+ } catch (e) {`
	`161`	`+ return formatFatalError('Compiler returned invalid JSON: ' + e.message);`
	`162`	`+ }`
	`163`	`+ output = translate.translateJsonCompilerOutput(output);`
`159`	`164`	`if (output == null) {`
`160`	`165`	`return formatFatalError('Failed to process output');`
`161`	`166`	`}`