-
Notifications
You must be signed in to change notification settings - Fork 495
Open
Labels
good first issuelow effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.nice to haveWe don’t see a good reason not to have it but won’t go out of our way to implement it.We don’t see a good reason not to have it but won’t go out of our way to implement it.refactor
Description
Command: solcjs --overwrite --abi --bin -o ./test/contract-artifacts ./test/contracts/*
When using native solc
, generated files have reasonable names like DumbContract.abi
, DumbContract.bin
(same as original). With solcjs filenames contain full path like: __test_contracts_DumbContract_sol_DumbContract.abi
Is this behaviour intended? It makes it painful to work with generated files. We do it in integration tests for one of my projects and its super weird to work with these files later: https://github.com/Neufund/TypeChain/blob/master/test/integration/DumbContract.spec.ts#L5
drgomesp, lrag and pierre-filliolaud
Metadata
Metadata
Assignees
Labels
good first issuelow effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.nice to haveWe don’t see a good reason not to have it but won’t go out of our way to implement it.We don’t see a good reason not to have it but won’t go out of our way to implement it.refactor