Applying code review.

Author: christianparpart

libsolidity/lsp/LanguageServer.cpp

@@ -216,31 +216,27 @@ void LanguageServer::changeConfiguration(Json::Value const& _settings)
 
 	if (jsonRemappings)
 	{
-		int typeFailureCount = 0;
+		bool typeFailures = false;
 		if (jsonRemappings.isArray())
 		{
 			vector<frontend::ImportRemapper::Remapping> remappings;
 			for (Json::Value const& jsonPath: jsonRemappings)
 			{
 				if (jsonPath.isObject())
-				{
 					remappings.emplace_back(ImportRemapper::Remapping{
 						jsonPath.get("context", "").asString(),
 						jsonPath.get("prefix", "").asString(),
 						jsonPath.get("target", "").asString(),
 					});
-				}
 				else
-				{
-					typeFailureCount++;
-				}
+					typeFailures = true;
 			}
-			m_fileRepository.setRemappings(move(remappings));
+			m_fileRepository.setRemappings(std::move(remappings));
 		}
 		else
-			++typeFailureCount;
+			typeFailures = true;
 
-		if (typeFailureCount)
+		if (typeFailures)
 			m_client.trace("Invalid JSON configuration passed. \"remappings\" should be of form [{\"context\":\"\", \"prefix\":\"foo\", \"target\":\"bar\"}].");
 
 	}