Skip to content

Commit 1582682

Browse files
authored
Merge pull request #12444 from ethereum/pylint-disable-too-many-warnings
[pylint] Disable the opinionated too-many-xyz warnings
2 parents 0769e4d + de364c5 commit 1582682

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

scripts/bytecodecompare/prepare_report.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ def parse_cli_output(source_file_name: Path, cli_output: str) -> FileReport:
187187
return file_report
188188

189189

190-
def prepare_compiler_input( # pylint: disable=too-many-arguments
190+
def prepare_compiler_input(
191191
compiler_path: Path,
192192
source_file_name: Path,
193193
optimize: bool,
@@ -256,7 +256,7 @@ def detect_metadata_cli_option_support(compiler_path: Path):
256256
return process.returncode == 0
257257

258258

259-
def run_compiler( # pylint: disable=too-many-arguments
259+
def run_compiler(
260260
compiler_path: Path,
261261
source_file_name: Path,
262262
optimize: bool,
@@ -320,7 +320,7 @@ def run_compiler( # pylint: disable=too-many-arguments
320320
return parse_cli_output(Path(source_file_name), process.stdout)
321321

322322

323-
def generate_report( # pylint: disable=too-many-arguments,too-many-locals
323+
def generate_report(
324324
source_file_names: List[str],
325325
compiler_path: Path,
326326
interface: CompilerInterface,

scripts/endToEndExtraction/verify-testcases.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
#
1010
# verify-testcases.py will compare both traces. If these traces are identical, the extracted tests were
1111
# identical with the tests specified in SolidityEndToEndTest.cpp.
12-
#
13-
# pylint: disable=too-many-instance-attributes
1412

1513
import re
1614
import os

scripts/error_codes.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,6 @@ def examine_id_coverage(top_dir, source_id_to_file_names, new_ids_only=False):
254254

255255

256256
def main(argv):
257-
# pylint: disable=too-many-branches, too-many-locals, too-many-statements
258-
259257
check = False
260258
fix = False
261259
no_confirm = False

scripts/pylintrc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,13 @@ disable=
2525
pointless-string-statement,
2626
redefined-outer-name,
2727
too-few-public-methods,
28-
too-many-public-methods
28+
too-many-arguments,
29+
too-many-branches,
30+
too-many-instance-attributes,
31+
too-many-locals,
32+
too-many-public-methods,
33+
too-many-statements,
34+
ungrouped-imports
2935

3036
[BASIC]
3137

0 commit comments

Comments
 (0)