Skip to content

Commit 3f84837

Browse files
authored
Merge pull request #13088 from ethereum/fix-new-pylint-warnings-after-upgrade
Fix new warnings from pylint 2.14 and adjust pylint config
2 parents a90bafd + f5e421f commit 3f84837

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -700,6 +700,7 @@ jobs:
700700
deepdiff
701701
colorama
702702
requests
703+
- run: pylint --version
703704
- run:
704705
name: Linting Python Scripts
705706
command: ./scripts/pylint_all.py

scripts/gas_diff_stats.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,11 @@ def try_parse(line):
8888
diff_kinds = [Diff.Minus, Diff.Plus]
8989
codegen_kinds = [Kind.IrOptimized, Kind.LegacyOptimized, Kind.Legacy]
9090
return tuple(
91-
sum([
91+
sum(
9292
val
9393
for (diff_kind, codegen_kind, val) in out
9494
if diff_kind == _diff_kind and codegen_kind == _codegen_kind
95-
])
95+
)
9696
for _diff_kind in diff_kinds
9797
for _codegen_kind in codegen_kinds
9898
)

scripts/pylintrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
# TODO: What could be eliminated in future PRs: invalid-name, pointless-string-statement, redefined-outer-name.
1818
disable=
1919
bad-indentation,
20-
bad-whitespace,
2120
duplicate-code,
2221
invalid-name,
2322
missing-docstring,

0 commit comments

Comments
 (0)