fixup! Calldata validation tests

wechman · wechman · commit 60e7e4a24c25 · 2022-08-11T07:39:02.000+02:00
diff --git a/test/libsolidity/semanticTests/abiEncoderV2/calldata_dynamic_array_to_memory.sol b/test/libsolidity/semanticTests/abiEncoderV2/calldata_dynamic_array_to_memory.sol
@@ -14,8 +14,6 @@ contract C {
     }
 }
 
-// ====
-// compileViaYul: also
 // ----
 // f(uint256[][]): 0x20, 2, 0x40, 0xa0, 2, 5, 6, 2, 7, 8 -> 0x20, 2, 0x40, 0xa0, 2, 5, 6, 2, 7, 8
 // f(uint256[][]): 0x20, 2, 0x40, 0xa0, 2, 5, 6, 2, 7, 8, 9 -> 0x20, 2, 0x40, 0xa0, 2, 5, 6, 2, 7, 8
diff --git a/test/libsolidity/semanticTests/abiEncoderV2/calldata_nested_array_reencode.sol b/test/libsolidity/semanticTests/abiEncoderV2/calldata_nested_array_reencode.sol
@@ -19,7 +19,6 @@ contract C {
 }
 // ====
 // revertStrings: debug
-// compileViaYul: also
 // ----
 // f(uint256[][]): 0x20, 1, 0x20, 0 -> 0x20, 0x80, 0x20, 1, 0x20, 0
 // f(uint256[][]): 0x20, 1, 0x20, 1 -> FAILURE, hex"08c379a0", 0x20, 0x1e, "Invalid calldata access stride"
diff --git a/test/libsolidity/semanticTests/abiEncoderV2/calldata_overlapped_dynamic_arrays.sol b/test/libsolidity/semanticTests/abiEncoderV2/calldata_overlapped_dynamic_arrays.sol
@@ -23,8 +23,6 @@ contract C {
     }
 }
 
-// ====
-// compileViaYul: also
 // ----
 // f_memory(uint256[],uint256[2]): 0x20, 1, 2 -> 0x60, 0x01, 0x02, 1, 2
 // f_memory(uint256[],uint256[2]): 0x40, 1, 2, 5, 6 -> 0x60, 1, 2, 2, 5, 6
diff --git a/test/libsolidity/semanticTests/abiEncoderV2/calldata_overlapped_nested_dynamic_arrays.sol b/test/libsolidity/semanticTests/abiEncoderV2/calldata_overlapped_nested_dynamic_arrays.sol
@@ -17,8 +17,6 @@ contract C {
     }
 }
 
-// ====
-// compileViaYul: also
 // ----
 // f_memory(uint256[][]): 0x20, 2, 0x40, 0x40, 2, 1, 2 -> 0x20, 2, 0x40, 0xa0, 2, 1, 2, 2, 1, 2
 // f_memory(uint256[][]): 0x20, 2, 0x40, 0x60, 2, 1, 2 -> 0x20, 2, 0x40, 0xa0, 2, 1, 2, 1, 2
diff --git a/test/libsolidity/semanticTests/abiEncoderV2/calldata_struct_array_reencode.sol b/test/libsolidity/semanticTests/abiEncoderV2/calldata_struct_array_reencode.sol
@@ -34,8 +34,6 @@ contract C {
 
 }
 
-// ====
-// compileViaYul: also
 // ----
 // f((uint256[])): 0x20, 0x20, 0 -> 0x20, 0x60, 0x20, 0x20, 0
 // f((uint256[])): 0x20, 0x20, 1 -> FAILURE
diff --git a/test/libsolidity/semanticTests/abiEncoderV2/calldata_three_dimensional_dynamic_array_index_access.sol b/test/libsolidity/semanticTests/abiEncoderV2/calldata_three_dimensional_dynamic_array_index_access.sol
@@ -25,7 +25,6 @@ contract C {
 }
 
 // ====
-// compileViaYul: also
 // revertStrings: debug
 // ----
 // f(uint256[][],uint256,uint256): 0x60, 0, 0, 2, 0x40, 0x80, 1, 7, 1, 8 -> 0x20, 0x20, 7
diff --git a/test/libsolidity/semanticTests/abiEncoderV2/calldata_with_garbage.sol b/test/libsolidity/semanticTests/abiEncoderV2/calldata_with_garbage.sol
@@ -40,8 +40,6 @@ contract C {
     }
 }
 
-// ====
-// compileViaYul: also
 // ----
 // f_memory(uint256[]): 0x80, 9, 9, 9, 0 -> 0x20, 0
 // f_memory(uint256[]): 0x80, 9, 9, 9, 1, 7 -> 0x20, 1, 7

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,6 @@ contract C {`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`
`17`		`-// ====`
`18`		`-// compileViaYul: also`
`19`	`17`	`// ----`
`20`	`18`	`// f(uint256[][]): 0x20, 2, 0x40, 0xa0, 2, 5, 6, 2, 7, 8 -> 0x20, 2, 0x40, 0xa0, 2, 5, 6, 2, 7, 8`
`21`	`19`	`// f(uint256[][]): 0x20, 2, 0x40, 0xa0, 2, 5, 6, 2, 7, 8, 9 -> 0x20, 2, 0x40, 0xa0, 2, 5, 6, 2, 7, 8`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ contract C {`
`19`	`19`	`}`
`20`	`20`	`// ====`
`21`	`21`	`// revertStrings: debug`
`22`		`-// compileViaYul: also`
`23`	`22`	`// ----`
`24`	`23`	`// f(uint256[][]): 0x20, 1, 0x20, 0 -> 0x20, 0x80, 0x20, 1, 0x20, 0`
`25`	`24`	`// f(uint256[][]): 0x20, 1, 0x20, 1 -> FAILURE, hex"08c379a0", 0x20, 0x1e, "Invalid calldata access stride"`
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,6 @@ contract C {`
`23`	`23`	`}`
`24`	`24`	`}`
`25`	`25`
`26`		`-// ====`
`27`		`-// compileViaYul: also`
`28`	`26`	`// ----`
`29`	`27`	`// f_memory(uint256[],uint256[2]): 0x20, 1, 2 -> 0x60, 0x01, 0x02, 1, 2`
`30`	`28`	`// f_memory(uint256[],uint256[2]): 0x40, 1, 2, 5, 6 -> 0x60, 1, 2, 2, 5, 6`
Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@ contract C {`
`17`	`17`	`}`
`18`	`18`	`}`
`19`	`19`
`20`		`-// ====`
`21`		`-// compileViaYul: also`
`22`	`20`	`// ----`
`23`	`21`	`// f_memory(uint256[][]): 0x20, 2, 0x40, 0x40, 2, 1, 2 -> 0x20, 2, 0x40, 0xa0, 2, 1, 2, 2, 1, 2`
`24`	`22`	`// f_memory(uint256[][]): 0x20, 2, 0x40, 0x60, 2, 1, 2 -> 0x20, 2, 0x40, 0xa0, 2, 1, 2, 1, 2`
Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,6 @@ contract C {`
`34`	`34`
`35`	`35`	`}`
`36`	`36`
`37`		`-// ====`
`38`		`-// compileViaYul: also`
`39`	`37`	`// ----`
`40`	`38`	`// f((uint256[])): 0x20, 0x20, 0 -> 0x20, 0x60, 0x20, 0x20, 0`
`41`	`39`	`// f((uint256[])): 0x20, 0x20, 1 -> FAILURE`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ contract C {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`// ====`
`28`		`-// compileViaYul: also`
`29`	`28`	`// revertStrings: debug`
`30`	`29`	`// ----`
`31`	`30`	`// f(uint256[][],uint256,uint256): 0x60, 0, 0, 2, 0x40, 0x80, 1, 7, 1, 8 -> 0x20, 0x20, 7`
Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,6 @@ contract C {`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
`43`		`-// ====`
`44`		`-// compileViaYul: also`
`45`	`43`	`// ----`
`46`	`44`	`// f_memory(uint256[]): 0x80, 9, 9, 9, 0 -> 0x20, 0`
`47`	`45`	`// f_memory(uint256[]): 0x80, 9, 9, 9, 1, 7 -> 0x20, 1, 7`