Skip to content

Commit 720db45

Browse files
authored
Merge pull request #13622 from ethereum/fix-failing-build
Silence integer precision loss warning for protobuf fuzzers.
2 parents db54e04 + 898fbe9 commit 720db45

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

test/tools/ossfuzz/CMakeLists.txt

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ if (OSSFUZZ)
7070
protobuf.a
7171
)
7272
set_target_properties(yul_proto_ossfuzz PROPERTIES LINK_FLAGS ${LIB_FUZZING_ENGINE})
73-
target_compile_options(yul_proto_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override)
73+
# The -Wno-* compile options are required for source files that
74+
# are auto-generated by the protobuf compiler because the compiler
75+
# does not generate warning-free C++ bindings with regard to
76+
# upstream Clang builds that are used by ossfuzz.
77+
target_compile_options(yul_proto_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override -Wno-shorten-64-to-32)
7478

7579
add_executable(
7680
yul_proto_diff_ossfuzz
@@ -88,7 +92,7 @@ if (OSSFUZZ)
8892
protobuf.a
8993
)
9094
set_target_properties(yul_proto_diff_ossfuzz PROPERTIES LINK_FLAGS ${LIB_FUZZING_ENGINE})
91-
target_compile_options(yul_proto_diff_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override)
95+
target_compile_options(yul_proto_diff_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override -Wno-shorten-64-to-32)
9296

9397
add_executable(yul_proto_diff_custom_mutate_ossfuzz
9498
yulProto_diff_ossfuzz.cpp
@@ -106,7 +110,7 @@ if (OSSFUZZ)
106110
protobuf.a
107111
)
108112
set_target_properties(yul_proto_diff_custom_mutate_ossfuzz PROPERTIES LINK_FLAGS ${LIB_FUZZING_ENGINE})
109-
target_compile_options(yul_proto_diff_custom_mutate_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override)
113+
target_compile_options(yul_proto_diff_custom_mutate_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override -Wno-shorten-64-to-32)
110114

111115
add_executable(stack_reuse_codegen_ossfuzz
112116
StackReuseCodegenFuzzer.cpp
@@ -131,6 +135,7 @@ if (OSSFUZZ)
131135
-Wno-unused-parameter
132136
-Wno-zero-length-array
133137
-Wno-suggest-destructor-override
138+
-Wno-shorten-64-to-32
134139
)
135140

136141
add_executable(abiv2_proto_ossfuzz
@@ -151,7 +156,7 @@ if (OSSFUZZ)
151156
protobuf.a
152157
)
153158
set_target_properties(abiv2_proto_ossfuzz PROPERTIES LINK_FLAGS ${LIB_FUZZING_ENGINE})
154-
target_compile_options(abiv2_proto_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override)
159+
target_compile_options(abiv2_proto_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override -Wno-shorten-64-to-32)
155160

156161
add_executable(abiv2_isabelle_ossfuzz
157162
AbiV2IsabelleFuzzer.cpp
@@ -173,7 +178,7 @@ if (OSSFUZZ)
173178
gmp.a
174179
)
175180
set_target_properties(abiv2_isabelle_ossfuzz PROPERTIES LINK_FLAGS ${LIB_FUZZING_ENGINE})
176-
target_compile_options(abiv2_isabelle_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override)
181+
target_compile_options(abiv2_isabelle_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override -Wno-shorten-64-to-32)
177182

178183
add_executable(sol_proto_ossfuzz
179184
solProtoFuzzer.cpp
@@ -193,7 +198,7 @@ if (OSSFUZZ)
193198
protobuf.a
194199
)
195200
set_target_properties(sol_proto_ossfuzz PROPERTIES LINK_FLAGS ${LIB_FUZZING_ENGINE})
196-
target_compile_options(sol_proto_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override)
201+
target_compile_options(sol_proto_ossfuzz PUBLIC ${COMPILE_OPTIONS} -Wno-sign-conversion -Wno-suggest-destructor-override -Wno-inconsistent-missing-destructor-override -Wno-shorten-64-to-32)
197202
else()
198203
add_library(solc_ossfuzz
199204
solc_ossfuzz.cpp

0 commit comments

Comments
 (0)