Skip to content

Commit 7fc2253

Browse files
committed
externalTests: Make comments about failing presets less terse
1 parent 3e1aee1 commit 7fc2253

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

test/externalTests/gnosis-v2.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ function gnosis_safe_test
4040
local config_file="truffle-config.js"
4141

4242
local compile_only_presets=(
43-
legacy-no-optimize # "Error: while migrating GnosisSafe: Returned error: base fee exceeds gas limit"
43+
legacy-no-optimize # Compiles but migrations run out of gas: "Error: while migrating GnosisSafe: Returned error: base fee exceeds gas limit"
4444
)
4545
local settings_presets=(
4646
"${compile_only_presets[@]}"
47-
#ir-no-optimize # "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
48-
#ir-optimize-evm-only # "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
47+
#ir-no-optimize # Compilation fails with "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
48+
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
4949
ir-optimize-evm+yul
5050
legacy-optimize-evm-only
5151
legacy-optimize-evm+yul

test/externalTests/gnosis.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ function gnosis_safe_test
4242
local compile_only_presets=()
4343
local settings_presets=(
4444
"${compile_only_presets[@]}"
45-
#ir-no-optimize # "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
46-
#ir-optimize-evm-only # "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
45+
#ir-no-optimize # Compilation fails with "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
46+
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
4747
ir-optimize-evm+yul
48-
#legacy-no-optimize # "Stack too deep" error
49-
#legacy-optimize-evm-only # "Stack too deep" error
48+
#legacy-no-optimize # Compilation fails with "Stack too deep" error
49+
#legacy-optimize-evm-only # Compilation fails with "Stack too deep" error
5050
legacy-optimize-evm+yul
5151
)
5252

test/externalTests/zeppelin.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ function zeppelin_test
4444
)
4545
local settings_presets=(
4646
"${compile_only_presets[@]}"
47-
#ir-no-optimize # "YulException: Variable var_account_852 is 4 slot(s) too deep inside the stack."
48-
#ir-optimize-evm-only # "YulException: Variable var_account_852 is 4 slot(s) too deep inside the stack."
47+
#ir-no-optimize # Compilation fails with "YulException: Variable var_account_852 is 4 slot(s) too deep inside the stack."
48+
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_account_852 is 4 slot(s) too deep inside the stack."
4949
legacy-no-optimize
5050
legacy-optimize-evm-only
5151
legacy-optimize-evm+yul

0 commit comments

Comments
 (0)