Skip to content

Commit afc3d72

Browse files
authored
Merge pull request #12624 from ethereum/adjust-solc-js-installation
Adjust solc-js installation to match the new release process
2 parents 2b141c2 + f5b3455 commit afc3d72

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

scripts/bytecodecompare/storebytecode.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ TMPDIR=$(mktemp -d)
5252
popd
5353

5454
cp "$REPO_ROOT/scripts/bytecodecompare/prepare_report.js" .
55-
npm install solc-js/
55+
npm install ./solc-js/dist
5656

5757
echo "Running the compiler..."
5858
# shellcheck disable=SC2035

scripts/solc-bin/bytecode_reports_for_modified_binaries.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,11 @@ for binary_name in $platform_binaries; do
149149
if [[ $platform == emscripten-wasm32 ]] || [[ $platform == emscripten-asmjs ]]; then
150150
ln -sf "${solc_bin_dir}/${platform}/${binary_name}" "${solcjs_dir}/soljson.js"
151151
ln -sf "${solc_bin_dir}/${platform}/${binary_name}" "${solcjs_dir}/dist/soljson.js"
152-
ln -s "${solcjs_dir}" solc-js
152+
npm install "${solcjs_dir}/dist"
153153
cp "${script_dir}/bytecodecompare/prepare_report.js" prepare_report.js
154154

155155
validate_reported_version \
156-
"$(solc-js/dist/solc.js --version)" \
156+
"$(node_modules/solc/solc.js --version)" \
157157
"$solidity_version_and_commit"
158158

159159
# shellcheck disable=SC2035

test/externalTests/colony.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ function colony_test
5959
[[ $BINARY_TYPE == native ]] && replace_global_solc "$BINARY_PATH"
6060

6161
neutralize_package_json_hooks
62-
force_truffle_compiler_settings "$config_file" "$BINARY_TYPE" "${DIR}/solc" "$(first_word "$SELECTED_PRESETS")"
62+
force_truffle_compiler_settings "$config_file" "$BINARY_TYPE" "${DIR}/solc/dist" "$(first_word "$SELECTED_PRESETS")"
6363
yarn install
6464
git submodule update --init
6565

@@ -69,10 +69,10 @@ function colony_test
6969
cd ..
7070

7171
replace_version_pragmas
72-
[[ $BINARY_TYPE == solcjs ]] && force_solc_modules "${DIR}/solc"
72+
[[ $BINARY_TYPE == solcjs ]] && force_solc_modules "${DIR}/solc/dist"
7373

7474
for preset in $SELECTED_PRESETS; do
75-
truffle_run_test "$config_file" "$BINARY_TYPE" "${DIR}/solc" "$preset" "${compile_only_presets[*]}" compile_fn test_fn
75+
truffle_run_test "$config_file" "$BINARY_TYPE" "${DIR}/solc/dist" "$preset" "${compile_only_presets[*]}" compile_fn test_fn
7676
done
7777
}
7878

test/externalTests/gnosis-v2.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,14 @@ function gnosis_safe_test
6363

6464
neutralize_package_lock
6565
neutralize_package_json_hooks
66-
force_truffle_compiler_settings "$config_file" "$BINARY_TYPE" "${DIR}/solc" "$(first_word "$SELECTED_PRESETS")"
66+
force_truffle_compiler_settings "$config_file" "$BINARY_TYPE" "${DIR}/solc/dist" "$(first_word "$SELECTED_PRESETS")"
6767
npm install --package-lock
6868

6969
replace_version_pragmas
70-
[[ $BINARY_TYPE == solcjs ]] && force_solc_modules "${DIR}/solc"
70+
[[ $BINARY_TYPE == solcjs ]] && force_solc_modules "${DIR}/solc/dist"
7171

7272
for preset in $SELECTED_PRESETS; do
73-
truffle_run_test "$config_file" "$BINARY_TYPE" "${DIR}/solc" "$preset" "${compile_only_presets[*]}" compile_fn test_fn
73+
truffle_run_test "$config_file" "$BINARY_TYPE" "${DIR}/solc/dist" "$preset" "${compile_only_presets[*]}" compile_fn test_fn
7474
done
7575
}
7676

test/externalTests/gnosis.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,14 @@ function gnosis_safe_test
6161

6262
neutralize_package_lock
6363
neutralize_package_json_hooks
64-
force_truffle_compiler_settings "$config_file" "$BINARY_TYPE" "${DIR}/solc" "$(first_word "$SELECTED_PRESETS")"
64+
force_truffle_compiler_settings "$config_file" "$BINARY_TYPE" "${DIR}/solc/dist" "$(first_word "$SELECTED_PRESETS")"
6565
npm install --package-lock
6666

6767
replace_version_pragmas
68-
[[ $BINARY_TYPE == solcjs ]] && force_solc_modules "${DIR}/solc"
68+
[[ $BINARY_TYPE == solcjs ]] && force_solc_modules "${DIR}/solc/dist"
6969

7070
for preset in $SELECTED_PRESETS; do
71-
truffle_run_test "$config_file" "$BINARY_TYPE" "${DIR}/solc" "$preset" "${compile_only_presets[*]}" compile_fn test_fn
71+
truffle_run_test "$config_file" "$BINARY_TYPE" "${DIR}/solc/dist" "$preset" "${compile_only_presets[*]}" compile_fn test_fn
7272
done
7373
}
7474

0 commit comments

Comments
 (0)