lsp: Limit resolvesToRegularFile()'s recursion depth to 10.

christianparpart · christianparpart · commit c8074d2c6e5e · 2022-08-24T16:27:08.000+02:00
diff --git a/libsolidity/lsp/LanguageServer.cpp b/libsolidity/lsp/LanguageServer.cpp
@@ -58,14 +58,15 @@ namespace fs = boost::filesystem;
 namespace
 {
 
-bool resolvesToRegularFile(boost::filesystem::path _path)
+bool resolvesToRegularFile(boost::filesystem::path _path, int maxRecursionDepth = 10)
 {
 	fs::file_status fileStatus = fs::status(_path);
 
-	while (fileStatus.type() == fs::file_type::symlink_file)
+	while (fileStatus.type() == fs::file_type::symlink_file && maxRecursionDepth > 0)
 	{
 		_path = boost::filesystem::read_symlink(_path);
 		fileStatus = fs::status(_path);
+		maxRecursionDepth--;
 	}
 
 	return fileStatus.type() == fs::file_type::regular_file;

Original file line number	Diff line number	Diff line change
`@@ -58,14 +58,15 @@ namespace fs = boost::filesystem;`
`58`	`58`	`namespace`
`59`	`59`	`{`
`60`	`60`
`61`		`-bool resolvesToRegularFile(boost::filesystem::path _path)`
	`61`	`+bool resolvesToRegularFile(boost::filesystem::path _path, int maxRecursionDepth = 10)`
`62`	`62`	`{`
`63`	`63`	`fs::file_status fileStatus = fs::status(_path);`
`64`	`64`
`65`		`- while (fileStatus.type() == fs::file_type::symlink_file)`
	`65`	`+ while (fileStatus.type() == fs::file_type::symlink_file && maxRecursionDepth > 0)`
`66`	`66`	`{`
`67`	`67`	`_path = boost::filesystem::read_symlink(_path);`
`68`	`68`	`fileStatus = fs::status(_path);`
	`69`	`+ maxRecursionDepth--;`
`69`	`70`	`}`
`70`	`71`
`71`	`72`	`return fileStatus.type() == fs::file_type::regular_file;`