Adding Changelog entry.

Author: christianparpart

Changelog.md

@@ -4,6 +4,7 @@ Language Features:
 
 
 Compiler Features:
+ * Language Server: Add configuration option to apply custom remappings via ``remappings`` in the LSP settings object.
 
 
 Bugfixes:

libsolidity/lsp/LanguageServer.cpp

@@ -222,7 +222,12 @@ void LanguageServer::changeConfiguration(Json::Value const& _settings)
 			vector<frontend::ImportRemapper::Remapping> remappings;
 			for (Json::Value const& jsonPath: jsonRemappings)
 			{
-				if (jsonPath.isObject())
+				if (
+					jsonPath.isObject() &&
+					jsonPath.get("context", "").isString() &&
+					jsonPath.get("prefix", "").isString() &&
+					jsonPath.get("target", "").isString()
+				)
 					remappings.emplace_back(ImportRemapper::Remapping{
 						jsonPath.get("context", "").asString(),
 						jsonPath.get("prefix", "").asString(),

test/lsp.py

@@ -1541,6 +1541,28 @@ def test_custom_includes(self, solc: JsonRpcProcess) -> None:
         self.expect_equal(len(diagnostics), 1, "no diagnostics")
         self.expect_diagnostic(diagnostics[0], code=2018, lineNo=5, startEndColumns=(4, 62))
 
+    def test_remapping_wrong_paramateres(self, solc: JsonRpcProcess) -> None:
+        self.setup_lsp(solc, expose_project_root=False)
+        solc.send_notification(
+            'workspace/didChangeConfiguration', {
+                'settings': {
+                    'remappings': [
+                        {
+                            'context': False,
+                            'prefix': 1,
+                            'target': f"{self.project_root_dir}/other-include-dir/otherlib/"
+                        }
+                    ]
+                }
+            }
+        )
+
+        response = solc.receive_message()
+        self.expect_equal(response["method"], "$/logTrace")
+
+        if not response["params"]["message"].startswith("Invalid JSON configuration passed."):
+            raise Exception("Expected JSON error.")
+
     def test_remapping(self, solc: JsonRpcProcess) -> None:
         self.setup_lsp(solc, expose_project_root=False)
         solc.send_notification(