Make the message about name not referring to a user-defined type more generic

Author: wechman

libsolidity/analysis/DeclarationTypeChecker.cpp

@@ -190,7 +190,7 @@ void DeclarationTypeChecker::endVisit(UserDefinedTypeName const& _typeName)
 		m_errorReporter.fatalTypeError(
 			5172_error,
 			_typeName.location(),
-			"Name has to refer to a struct, enum or contract."
+			"Name has to refer to a user-defined type."
 		);
 	}
 }

test/libsolidity/syntaxTests/errors/error_as_function_param.sol

@@ -1,4 +1,4 @@
 error E(uint);
 function f(E x) pure returns (uint) {}
 // ----
-// TypeError 5172: (26-27): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (26-27): Name has to refer to a user-defined type.

test/libsolidity/syntaxTests/errors/using_2.sol

@@ -9,4 +9,4 @@ contract C {
     }
 }
 // ----
-// TypeError 5172: (91-92): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (91-92): Name has to refer to a user-defined type.

test/libsolidity/syntaxTests/errors/weird3.sol

@@ -4,4 +4,4 @@ contract C {
     E x;
 }
 // ----
-// TypeError 5172: (29-30): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (29-30): Name has to refer to a user-defined type.

test/libsolidity/syntaxTests/errors/weird4.sol

@@ -6,4 +6,4 @@ contract C {
     }
 }
 // ----
-// TypeError 5172: (64-65): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (64-65): Name has to refer to a user-defined type.

test/libsolidity/syntaxTests/iceRegressionTests/identifier_collision_return_declare.sol

@@ -2,4 +2,4 @@ contract C {
         function ( uint ) external returns ( a [ ] calldata ) public a = ( 1 / 2 ) ;
 }
 // ----
-// TypeError 5172: (58-59): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (58-59): Name has to refer to a user-defined type.

test/libsolidity/syntaxTests/nameAndTypeResolution/291_modifier_is_not_a_valid_typename.sol

@@ -6,4 +6,4 @@ contract test {
     }
 }
 // ----
-// TypeError 5172: (77-80): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (77-80): Name has to refer to a user-defined type.

test/libsolidity/syntaxTests/nameAndTypeResolution/292_modifier_is_not_a_valid_typename_is_not_fatal.sol

@@ -7,4 +7,4 @@ contract test {
     }
 }
 // ----
-// TypeError 5172: (77-80): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (77-80): Name has to refer to a user-defined type.

test/libsolidity/syntaxTests/nameAndTypeResolution/293_function_is_not_a_valid_typename.sol

@@ -7,4 +7,4 @@ contract test {
     }
 }
 // ----
-// TypeError 5172: (85-88): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (85-88): Name has to refer to a user-defined type.

test/libsolidity/syntaxTests/scoping/name_shadowing_function_parameter_vs_struct_enum.sol

@@ -17,4 +17,4 @@ contract C {
 // Warning 2519: (207-226): This declaration shadows an existing declaration.
 // Warning 2519: (228-254): This declaration shadows an existing declaration.
 // Warning 2519: (314-327): This declaration shadows an existing declaration.
-// TypeError 5172: (104-114): Name has to refer to a struct, enum or contract.
+// TypeError 5172: (104-114): Name has to refer to a user-defined type.