Skip to content

Commit ea2754c

Browse files
authored
Merge pull request #13063 from ethereum/gnosis-euler-ext-test-workarounds
External test workarounds for Gnosis and Euler external test failures
2 parents dcf23ed + c861207 commit ea2754c

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

test/externalTests/ens.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ function ens_test
6565
force_hardhat_compiler_settings "$config_file" "$(first_word "$SELECTED_PRESETS")"
6666
yarn install
6767

68-
# With ethers.js 5.6.2 many tests for revert messages fail.
69-
# TODO: Remove when https://github.com/ethers-io/ethers.js/discussions/2849 is resolved.
70-
71-
7268
replace_version_pragmas
7369
neutralize_packaged_contracts
7470

test/externalTests/euler.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,6 @@ function euler_test
7878
force_hardhat_unlimited_contract_size "$config_file"
7979
npm install
8080

81-
# With ethers.js 5.6.2 many tests for revert messages fail.
82-
# TODO: Remove when https://github.com/ethers-io/ethers.js/discussions/2849 is resolved.
83-
npm install [email protected]
84-
8581
replace_version_pragmas
8682
neutralize_packaged_contracts
8783

test/externalTests/gnosis.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@ function gnosis_safe_test
9494
npm install
9595
npm install hardhat-gas-reporter
9696

97+
# Typescript compilation fails with typescript >= 4.7:
98+
# Error: Debug Failure. False expression: Non-string value passed to `ts.resolveTypeReferenceDirective`
99+
npm install "typescript@<4.7.0"
100+
97101
# With ethers.js 5.6.2 many tests for revert messages fail.
98102
# TODO: Remove when https://github.com/ethers-io/ethers.js/discussions/2849 is resolved.
99103
npm install [email protected]

0 commit comments

Comments
 (0)