Skip to content

Commit fb3d0a8

Browse files
authored
Merge pull request #13643 from ethereum/ext-gp2-bug-fix
Fix gp2 ext test failing to build, not being able to resolve the the keyv dependency
2 parents 8830be9 + bc75672 commit fb3d0a8

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

scripts/externalTests/update_external_repos.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,9 @@ cd "$target_dir"
8080
clone_repo brinktrade brink-core
8181
clone_repo dapphub dappsys-monolithic
8282
clone_repo element-fi elf-contracts
83-
clone_repo ensdomains ens
8483
clone_repo ensdomains ens-contracts
8584
clone_repo euler-xyz euler-contracts
86-
clone_repo gnosis gp-v2-contracts
85+
clone_repo cowprotocol contracts gp2-contracts
8786
clone_repo gnosis mock-contract
8887
clone_repo gnosis util-contracts
8988
clone_repo JoinColony colonyNetwork
@@ -102,10 +101,9 @@ clone_repo yieldprotocol yield-liquidator-v2
102101
sync_branch brink-core master
103102
sync_branch dappsys-monolithic master
104103
sync_branch elf-contracts main
105-
sync_branch ens master
106104
sync_branch ens-contracts master
107105
sync_branch euler-contracts master
108-
sync_branch gp-v2-contracts main
106+
sync_branch gp2-contracts main
109107
sync_branch mock-contract master
110108
sync_branch util-contracts main
111109
sync_branch colonyNetwork develop

test/externalTests/gp2.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ BINARY_TYPE="$1"
3131
BINARY_PATH="$(realpath "$2")"
3232
SELECTED_PRESETS="$3"
3333

34-
function compile_fn { npm run build; }
35-
function test_fn { npm test; }
34+
function compile_fn { yarn run build; }
35+
function test_fn { yarn test; }
3636

3737
function gp2_test
3838
{
39-
local repo="https://github.com/gnosis/gp-v2-contracts.git"
39+
local repo="https://github.com/cowprotocol/contracts.git"
4040
local ref_type=branch
4141
local ref=main
4242
local config_file="hardhat.config.ts"
@@ -67,11 +67,11 @@ function gp2_test
6767
force_hardhat_compiler_binary "$config_file" "$BINARY_TYPE" "$BINARY_PATH"
6868
force_hardhat_compiler_settings "$config_file" "$(first_word "$SELECTED_PRESETS")" "$config_var"
6969
force_hardhat_unlimited_contract_size "$config_file" "$config_var"
70-
npm install
70+
yarn
7171

7272
# New hardhat release breaks GP2 tests, and since GP2 repository has been archived, we are pinning hardhat
7373
# to the previous stable version. See https://github.com/ethereum/solidity/pull/13485
74-
npm install [email protected]
74+
7575

7676
# Some dependencies come with pre-built artifacts. We want to build from scratch.
7777
rm -r node_modules/@gnosis.pm/safe-contracts/build/

0 commit comments

Comments
 (0)