chore: report number of failed outgoing requests

Author: ogenev

crates/metrics/src/overlay.rs

@@ -20,6 +20,7 @@ use crate::{
 #[derive(Clone)]
 pub struct OverlayMetrics {
     pub message_total: IntCounterVec,
+    pub failed_message_sent: IntCounterVec,
     pub utp_outcome_total: IntCounterVec,
     pub utp_active_gauge: IntGaugeVec,
     pub utp_connection_duration: HistogramVec,
@@ -38,6 +39,14 @@ impl OverlayMetrics {
             &["protocol", "direction", "type"],
             registry
         )?;
+        let failed_message_sent = register_int_counter_vec_with_registry!(
+            opts!(
+                "trin_failed_message_sent",
+                "count all network messages sent"
+            ),
+            &["protocol", "direction", "type"],
+            registry
+        )?;
         let utp_outcome_total = register_int_counter_vec_with_registry!(
             opts!(
                 "trin_utp_outcome_total",
@@ -80,6 +89,7 @@ impl OverlayMetrics {
         )?;
         Ok(Self {
             message_total,
+            failed_message_sent,
             utp_outcome_total,
             utp_active_gauge,
             utp_connection_duration,
@@ -129,13 +139,29 @@ impl OverlayMetricsReporter {
         self.increment_message_total(MessageDirectionLabel::Received, response.into());
     }
 
+    pub fn report_failed_outbound_request(&self, request: &Request) {
+        self.increment_failed_message_sent(MessageDirectionLabel::Sent, request.into());
+    }
+
     fn increment_message_total(&self, direction: MessageDirectionLabel, message: MessageLabel) {
         let labels: [&str; 3] = [&self.protocol, direction.into(), message.into()];
         self.overlay_metrics
             .message_total
             .with_label_values(&labels)
             .inc();
     }
+    /// Increment the failed message sent metric
+    fn increment_failed_message_sent(
+        &self,
+        direction: MessageDirectionLabel,
+        message: MessageLabel,
+    ) {
+        let labels: [&str; 3] = [&self.protocol, direction.into(), message.into()];
+        self.overlay_metrics
+            .failed_message_sent
+            .with_label_values(&labels)
+            .inc();
+    }
     /// Increase the total bytes inbound metric by the given length.
     pub fn report_bytes_inbound(&self, bytes_len: u64) {
         let labels: [&str; 1] = [&self.protocol];

crates/portalnet/src/overlay/service/manager.rs

@@ -309,7 +309,11 @@ impl<
                                 self.metrics.report_inbound_response(&response);
                                 self.process_response(response, request.destination, request.request, request.query_id, request.request_permit)
                             }
-                            Err(error) => self.process_request_failure(response.request_id, request.destination, error),
+                            Err(error) => {
+                                // Metric repord failed request
+                                self.metrics.report_failed_outbound_request(&request.request);
+                                self.process_request_failure(response.request_id, request.destination, error)
+                            },
                         }
 
                     } else {