Skip to content

Commit eef1184

Browse files
authored
chore: bump discv5 to 0.9 includes NAT fixes (#1639)
1 parent 314309c commit eef1184

File tree

8 files changed

+78
-86
lines changed

8 files changed

+78
-86
lines changed

Cargo.lock

Lines changed: 60 additions & 67 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ chrono = "0.4.38"
4545
clap = { version = "4.2.1", features = ["derive"] }
4646
delay_map = "0.4.0"
4747
directories = "3.0"
48-
discv5 = { version = "0.4.1", features = ["serde"] }
48+
discv5 = { git = "https://github.com/kolbyml/discv5", rev = "7dcd74031aa98c220c2984bbc2274c414b6f709f", features = ["serde"] }
4949
env_logger = "0.9.0"
5050
eth_trie = "0.5.0"
5151
ethereum_hashing = "0.7.0"

bin/portal-bridge/src/cli.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,8 @@ impl FromStr for ClientType {
267267
impl From<&Enr> for ClientType {
268268
fn from(enr: &Enr) -> Self {
269269
let client_id = enr
270-
.get(ENR_PORTAL_CLIENT_KEY)
271-
.and_then(|v| String::from_utf8(v.to_vec()).ok());
270+
.get_decodable::<String>(ENR_PORTAL_CLIENT_KEY)
271+
.and_then(|v| v.ok());
272272
if let Some(client_id) = client_id {
273273
if client_id.starts_with("t") {
274274
ClientType::Trin

crates/ethportal-api/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ lazy_static.workspace = true
3434
once_cell = "1.17"
3535
quickcheck.workspace = true
3636
rand.workspace = true
37-
rlp = "0.5.0"
3837
rs_merkle = "1.4.2"
3938
secp256k1 = { version = "0.29.0", features = ["global-context", "recovery", "rand"] }
4039
serde = { workspace = true, features = ["rc"] }

crates/ethportal-api/src/types/enr.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,19 @@ use std::{
44
str::FromStr,
55
};
66

7+
use alloy_rlp::{Encodable, RlpDecodableWrapper, RlpEncodableWrapper};
78
use discv5::enr::{CombinedKey, Enr as Discv5Enr};
89
use rand::Rng;
9-
use rlp::Encodable;
1010
use serde::{Deserialize, Serialize};
1111
use serde_json::Value;
1212
use ssz::DecodeError;
1313
use validator::ValidationError;
1414

1515
pub type Enr = Discv5Enr<CombinedKey>;
1616

17-
#[derive(Debug, PartialEq, Clone, Serialize, Deserialize)]
17+
#[derive(
18+
Debug, PartialEq, Clone, Serialize, Deserialize, RlpEncodableWrapper, RlpDecodableWrapper,
19+
)]
1820
pub struct SszEnr(pub Enr);
1921

2022
impl SszEnr {
@@ -76,11 +78,13 @@ impl ssz::Encode for SszEnr {
7678
}
7779

7880
fn ssz_append(&self, buf: &mut Vec<u8>) {
79-
buf.append(&mut self.rlp_bytes().to_vec());
81+
self.encode(buf);
8082
}
8183

8284
fn ssz_bytes_len(&self) -> usize {
83-
self.rlp_bytes().to_vec().ssz_bytes_len()
85+
let mut buf = vec![];
86+
self.encode(&mut buf);
87+
buf.ssz_bytes_len()
8488
}
8589
}
8690

0 commit comments

Comments
 (0)