Remove Web3ValidationError dependency on eth-utils ValidationError

Author: fselmo

newsfragments/3443.breaking.rst

@@ -0,0 +1 @@
+Remove ``Web3ValidationError`` dependence / inheritance from `eth-utils` ``ValidationError``.

tests/core/method-class/test_method.py

@@ -3,9 +3,6 @@
 )
 import pytest
 
-from eth_utils import (
-    ValidationError,
-)
 from eth_utils.toolz import (
     compose,
 )
@@ -15,6 +12,7 @@
     Web3,
 )
 from web3.exceptions import (
+    Web3ValidationError,
     Web3ValueError,
 )
 from web3.method import (
@@ -160,34 +158,36 @@ def test_empty_mungers_for_property_with_no_input_parameters(empty):
     assert method.input_munger(object(), [], {}) == ()
 
 
-def test_default_munger_for_property_with_input_parameters_raises_ValidationError():
+def test_default_munger_for_property_with_input_params_raises_validation_error():
     method = Method(
         is_property=True,
         json_rpc_method="eth_method",
     )
     with pytest.raises(
-        ValidationError, match="Parameters cannot be passed to a property"
+        Web3ValidationError, match="Parameters cannot be passed to a property"
     ):
         method.input_munger(object(), [1], {})
 
 
 @pytest.mark.parametrize(
     "empty", ([], (), None), ids=["empty-list", "empty-tuple", "None"]
 )
-def test_empty_mungers_for_property_with_input_parameters_raises_ValidationError(empty):
+def test_empty_mungers_for_property_with_input_params_raises_validation_error(empty):
     method = Method(
         is_property=True,
         mungers=empty,
         json_rpc_method="eth_method",
     )
     with pytest.raises(
-        ValidationError, match="Parameters cannot be passed to a property"
+        Web3ValidationError, match="Parameters cannot be passed to a property"
     ):
         method.input_munger(object(), [1], {})
 
 
-def test_property_with_mungers_raises_ValidationError():
-    with pytest.raises(ValidationError, match="Mungers cannot be used with a property"):
+def test_property_with_mungers_raises_validation_error():
+    with pytest.raises(
+        Web3ValidationError, match="Mungers cannot be used with a property"
+    ):
         Method(
             is_property=True,
             mungers=[lambda m, z, y: "success"],

web3/exceptions.py

@@ -8,10 +8,6 @@
     Union,
 )
 
-from eth_utils import (
-    ValidationError,
-)
-
 from web3.types import (
     BlockData,
     RPCResponse,
@@ -184,8 +180,7 @@ class FallbackNotFound(Web3Exception):
     """
 
 
-# type ignored because subclassing ValidationError which has type Any
-class Web3ValidationError(Web3Exception, ValidationError):  # type: ignore[misc]
+class Web3ValidationError(Web3Exception):
     """
     Raised when a supplied value is invalid.
     """