Skip to content

Commit 2bd70d8

Browse files
committed
Update geth fixture to use geth v1.15.5
1 parent 1976bc0 commit 2bd70d8

File tree

10 files changed

+21
-9
lines changed

10 files changed

+21
-9
lines changed

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ parameters:
44
# NOTE: Do not update the `geth_version` manually. It is updated during the
55
# integration test fixture generation.
66
geth_version:
7-
default: "1.14.12"
7+
default: "1.15.5"
88
type: string
99
go_version:
10-
default: "1.22.4"
10+
default: "1.24.1"
1111
type: string
1212

1313
common: &common

docs/contributing.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,13 +365,13 @@ Geth Fixtures
365365

366366
.. code:: sh
367367
368-
$ python -m geth.install v1.14.12
368+
$ python -m geth.install v1.15.5
369369
370370
2. Specify the Geth binary and run the fixture creation script (from within the web3.py directory):
371371

372372
.. code:: sh
373373
374-
$ GETH_BINARY=~/.py-geth/geth-v1.14.12/bin/geth python ./tests/integration/generate_fixtures/go_ethereum.py
374+
$ GETH_BINARY=~/.py-geth/geth-v1.15.5/bin/geth python ./tests/integration/generate_fixtures/go_ethereum.py
375375
376376
3. The output of this script is your fixture, a zip file, which is now stored in ``/tests/integration/``.
377377
The ``/tests/integration/go_ethereum/conftest.py`` and

newsfragments/3636.internal.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Update integration test fixture to use latest geth version ``v1.15.5``.

tests/integration/generate_fixtures/common.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,11 @@
5959
# post-merge, timestamp is used for network transitions
6060
"shanghaiTime": 0,
6161
"cancunTime": 0,
62+
"pragueTime": 0,
63+
"blobSchedule": {
64+
"cancun": {"target": 3, "max": 6, "baseFeeUpdateFraction": 3338477},
65+
"prague": {"target": 6, "max": 9, "baseFeeUpdateFraction": 5007716},
66+
},
6267
},
6368
"nonce": "0x0",
6469
"alloc": {
-47.4 KB
Binary file not shown.
48.5 KB
Binary file not shown.

tests/integration/go_ethereum/conftest.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
)
3535

3636
KEYFILE_PW = "web3py-test"
37-
GETH_FIXTURE_ZIP = "geth-1.14.12-fixture.zip"
37+
GETH_FIXTURE_ZIP = "geth-1.15.5-fixture.zip"
3838

3939

4040
@pytest.fixture(scope="module")
@@ -97,12 +97,16 @@ def base_geth_command_arguments(geth_binary, datadir):
9797
"2",
9898
"--password",
9999
os.path.join(datadir, "keystore", "pw.txt"),
100+
# in order to raise on underpriced transactions, ``txpool.nolocals`` is now
101+
# necessary: https://github.com/ethereum/go-ethereum/pull/31202
102+
"--txpool.nolocals",
100103
)
101104

102105

103106
@pytest.fixture(scope="module")
104107
def geth_zipfile_version(get_geth_version):
105-
if get_geth_version.major == 1 and get_geth_version.minor in [13, 14]:
108+
# TODO: Remove support for 1.13.x in next major version
109+
if get_geth_version.major == 1 and get_geth_version.minor in [13, 14, 15]:
106110
return GETH_FIXTURE_ZIP
107111
raise AssertionError("Unsupported geth version")
108112

tests/integration/go_ethereum/test_goethereum_legacy_ws.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ def _geth_command_arguments(ws_port, base_geth_command_arguments, geth_version):
4848
"--ipcdisable",
4949
"--allow-insecure-unlock",
5050
)
51-
if geth_version.minor not in [13, 14]:
51+
if geth_version.minor not in [13, 14, 15]:
52+
# TODO: remove support for 1.13.x in next major version
5253
raise AssertionError("Unsupported Geth version")
5354
else:
5455
raise AssertionError("Unsupported Geth version")

tests/integration/go_ethereum/test_goethereum_ws/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ def _geth_command_arguments(ws_port, base_geth_command_arguments, geth_version):
3333
"*",
3434
"--ipcdisable",
3535
)
36-
if geth_version.minor not in [13, 14]:
36+
if geth_version.minor not in [13, 14, 15]:
37+
# TODO: remove support for 1.13.x in the next major release
3738
raise AssertionError("Unsupported Geth version")
3839
else:
3940
raise AssertionError("Unsupported Geth version")

web3/tools/benchmark/node.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
kill_proc_gracefully,
2525
)
2626

27-
GETH_FIXTURE_ZIP = "geth-1.14.12-fixture.zip"
27+
GETH_FIXTURE_ZIP = "geth-1.15.5-fixture.zip"
2828

2929

3030
class GethBenchmarkFixture:

0 commit comments

Comments
 (0)