Skip to content

Commit 4da059c

Browse files
committed
Mark certain very flaky tests as xfail, strict=False
1 parent ef921ba commit 4da059c

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

web3/_utils/module_testing/eth_module.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2358,7 +2358,9 @@ async def test_async_eth_replace_transaction_gas_price_too_low(
23582358
with pytest.raises(Web3ValueError):
23592359
await async_w3.eth.replace_transaction(txn_hash, txn_params)
23602360

2361-
@flaky_geth_dev_mining
2361+
@pytest.mark.xfail(
2362+
reason="Very flaky on CI runs, hard to reproduce locally", strict=False
2363+
)
23622364
@pytest.mark.asyncio
23632365
async def test_async_eth_replace_transaction_gas_price_defaulting_minimum(
23642366
self, async_w3: "AsyncWeb3", async_keyfile_account_address: ChecksumAddress
@@ -2382,7 +2384,9 @@ async def test_async_eth_replace_transaction_gas_price_defaulting_minimum(
23822384
gas_price * 1.125
23832385
) # minimum gas price
23842386

2385-
@flaky_geth_dev_mining
2387+
@pytest.mark.xfail(
2388+
reason="Very flaky on CI runs, hard to reproduce locally", strict=False
2389+
)
23862390
@pytest.mark.asyncio
23872391
async def test_async_eth_replace_transaction_gas_price_defaulting_strategy_higher(
23882392
self, async_w3: "AsyncWeb3", async_keyfile_account_address: ChecksumAddress
@@ -2411,7 +2415,9 @@ def higher_gas_price_strategy(async_w3: "AsyncWeb3", txn: TxParams) -> Wei:
24112415
) # Strategy provides higher gas price
24122416
async_w3.eth.set_gas_price_strategy(None) # reset strategy
24132417

2414-
@flaky_geth_dev_mining
2418+
@pytest.mark.xfail(
2419+
reason="Very flaky on CI runs, hard to reproduce locally", strict=False
2420+
)
24152421
@pytest.mark.asyncio
24162422
async def test_async_eth_replace_transaction_gas_price_defaulting_strategy_lower(
24172423
self, async_w3: "AsyncWeb3", async_keyfile_account_address: ChecksumAddress

0 commit comments

Comments
 (0)