bugfix: middleware_onion.values() keyerror fix

- fix: sort
- fix: sort imports
- fix: lint and typecheck
- docs: release note

Author: antazoey

newsfragments/3596.bugfix.rst

@@ -0,0 +1 @@
+Fix issue where ``.values()`` raised a ``KeyError`` in ``NamedTupledOnion``

tests/core/datastructures/test_datastructures.py

@@ -4,8 +4,12 @@
 
 from web3.datastructures import (
     AttributeDict,
+    NamedElementOnion,
     tupleize_lists_nested,
 )
+from web3.middleware import (
+    GasPriceStrategyMiddleware,
+)
 
 
 def generate_random_value(depth=0, max_depth=3, key_type=None):
@@ -207,3 +211,11 @@ def test_AttributeDict_hashing_backwards_compatibility(input, error):
             assert hash(tuple(sorted(input.items()))) == hash(input)
     else:
         assert hash(tuple(sorted(input.items()))) == hash(input)
+
+
+def test_NamedElementOnion_values():
+    middleware = GasPriceStrategyMiddleware(None)
+    initial_items = [(middleware, "gas_price_strategy")]
+    named_element_onion = NamedElementOnion(initial_items)
+    actual = [x for x in named_element_onion.values()]
+    assert actual == [middleware]

web3/datastructures.py

@@ -17,6 +17,7 @@
     Tuple,
     TypeVar,
     Union,
+    ValuesView,
     cast,
 )
 
@@ -337,3 +338,6 @@ def __iter__(self) -> Iterator[TKey]:
         # This leads to typing issues, so it's better to use
         # ``as_tuple_of_middleware()`` to achieve the same result.
         return iter(self._reversed_middleware())  # type: ignore
+
+    def values(self) -> ValuesView[TValue]:
+        return ValuesView(self._queue)