-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Description
We don't seem to be testing certain transaction params. It isn't really our job to test clients via our library, but we should be testing at least one case of each of these to make sure formatters are working correctly for every transaction field.
Some that come to mind are eth_sendTransaction
and eth_sendRawTransaction
tests for each of:
- Sending access lists in type 1 transactions
- Sending access lists in type 2 transactions
- Sending access lists in type 4 transactions - perhaps just creating access lists locally for the transactions we are already sending in this test and attaching them to each of the transactions we send (both raw and send). This should test the full formatters for type 4 txs
Are blob transactions missing any obvious cases? 👀
Metadata
Metadata
Assignees
Labels
No labels