Lint test/blockchain, test/integration

Author: cgewecke

test/blockchain/chain.spec.ts

@@ -7,8 +7,8 @@ defaultLogger.silent = true
 
 // explicitly import util and buffer,
 // needed for karma-typescript bundling
-import * as util from 'util'
-import { Buffer } from 'buffer'
+import * as util from 'util' //eslint-disable-line @typescript-eslint/no-unused-vars
+import { Buffer } from 'buffer' //eslint-disable-line @typescript-eslint/no-unused-vars
 
 tape('[Chain]', (t) => {
   t.test('should test object creation without logger', (t) => {

test/integration/lightsync.ts

@@ -1,3 +1,6 @@
+/* eslint-disable */
+// TODO: re-enable linting. Disabled because much of test is commented out
+// resulting in unused variable false positives
 import tape from 'tape'
 import { FastEthereumService, LightEthereumService } from '../../lib/service'
 import MockServer from './mocks/mockserver'

test/integration/mocks/mockserver.ts

@@ -22,7 +22,7 @@ export default class MockServer extends Server {
     if (this.started) {
       return false
     }
-    super.start()
+    await super.start()
     await this.wait(1)
     if (this.location) {
       this.server = network.createServer(this.location)
@@ -33,8 +33,8 @@ export default class MockServer extends Server {
         })
       })
     }
-    this.server.on('connection', (connection: any) => {
-      this.connect(connection)
+    this.server.on('connection', async (connection: any) => {
+      await this.connect(connection)
     })
     return true
   }

test/integration/mocks/network.ts

@@ -1,6 +1,6 @@
 import { EventEmitter } from 'events'
 
-const Pipe = function (id: any) {
+const Pipe = function () {
   const buffer: any[] = []
   let closed = false
 
@@ -36,8 +36,8 @@ const Pipe = function (id: any) {
 } as any
 
 const Connection = function (protocols: any) {
-  const outgoing = new Pipe('OUT')
-  const incoming = new Pipe('IN')
+  const outgoing = new Pipe()
+  const incoming = new Pipe()
 
   return {
     local: (remoteId: any) => ({
@@ -73,6 +73,16 @@ export function createServer(location: any) {
   return servers[location].server
 }
 
+export function destroyConnection(id: any, location: any) {
+  if (servers[location]) {
+    const conn = servers[location].connections[id]
+    if (conn) {
+      conn.close()
+      delete servers[location].connections[id]
+    }
+  }
+}
+
 export function destroyServer(location: any) {
   if (servers[location]) {
     for (const id of Object.keys(servers[location].connections)) {
@@ -91,13 +101,3 @@ export function createConnection(id: any, location: any, protocols: any) {
   setTimeout(() => servers[location].server.emit('connection', connection.local(id)), 10)
   return connection.remote(location)
 }
-
-export function destroyConnection(id: any, location: any) {
-  if (servers[location]) {
-    const conn = servers[location].connections[id]
-    if (conn) {
-      conn.close()
-      delete servers[location].connections[id]
-    }
-  }
-}