Lint lib/sync

Author: cgewecke

lib/sync/fastsync.ts

@@ -132,7 +132,7 @@ export class FastSynchronizer extends Synchronizer {
    * @param  {Peer}     peer peer
    * @return {Promise}
    */
-  async announced(announcements: any[], peer: Peer) {
+  async announced(announcements: any[], _peer: Peer) {
     if (announcements.length) {
       const [hash, height] = announcements[announcements.length - 1]
       this.logger.debug(`New height: number=${height.toString(10)} hash=${short(hash)}`)

lib/sync/fetcher/blockfetcher.ts

@@ -99,7 +99,8 @@ export class BlockFetcher extends Fetcher {
    * @param  job job
    * @return {Peer}
    */
-  peer(job: any): Peer {
+  // TODO: find out what _job is supposed to be doing here...
+  peer(_job: any): Peer {
     return this.pool.idle((p: any) => p.eth)
   }
 }

lib/sync/fetcher/fetcher.ts

@@ -124,6 +124,8 @@ export class Fetcher extends Readable {
     if (job.state !== 'active') return
     if (result === undefined) {
       this.enqueue(job)
+      // TODO: should this promise actually float?
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       this.wait().then(() => {
         job.peer.idle = true
       })
@@ -270,7 +272,8 @@ export class Fetcher extends Readable {
    * @param  job job
    * @return {Peer}
    */
-  peer(job?: any) {
+  // TODO: what is job supposed to be?
+  peer(_job?: any) {
     return this.pool.idle()
   }
 
@@ -280,7 +283,7 @@ export class Fetcher extends Readable {
    * @param  peer
    * @return {Promise}
    */
-  request(job?: any, peer?: any): Promise<any> {
+  request(_job?: any, _peer?: any): Promise<any> {
     throw new Error('Unimplemented')
   }
 
@@ -290,7 +293,7 @@ export class Fetcher extends Readable {
    * @param  {Peer}   peer peer that handled task
    * @param  result result data
    */
-  process(job?: any, peer?: any, result?: any) {
+  process(_job?: any, _peer?: any, _result?: any) {
     throw new Error('Unimplemented')
   }
 
@@ -316,7 +319,7 @@ export class Fetcher extends Readable {
    * @param result fetch result
    * @return {Promise}
    */
-  async store(result?: any) {
+  async store(_result?: any) {
     throw new Error('Unimplemented')
   }
 

lib/sync/fetcher/headerfetcher.ts

@@ -72,7 +72,8 @@ export class HeaderFetcher extends BlockFetcher {
    * @param  job job
    * @return {Peer}
    */
-  peer(job: any): Peer {
+  // TODO: what is job supposed to be?
+  peer(_job: any): Peer {
     return this.pool.idle((p: any) => p.les && p.les.status.serveHeaders)
   }
 }

lib/sync/sync.ts

@@ -76,7 +76,8 @@ export class Synchronizer extends EventEmitter {
    * Returns true if peer can be used for syncing
    * @return {boolean}
    */
-  syncable(peer: any): boolean {
+  // TODO: evaluate syncability of peer
+  syncable(_peer: any): boolean {
     return true
   }