Codecov tuning (#3207)

* Add coverage checking and reporting for wallet CI runs

* Add coverage checking and reporting for genesis CI runs

* Add coverage run to rlp package workflow

* Use coverage script for CI coverage report generation

* Just run node tests for RLP

* Increase wallet test timeouts

* Increase wallet test timeout

* Only run node tests for coverage

* Comment out tests to see how codecov handles report generation and processing

* Add arguments for codecov upload action

* Add arguments for codecov upload action

* Revert "Comment out tests to see how codecov handles report generation and processing"

This reverts commit 783dae0.

* Revert "Add arguments for codecov upload action"

This reverts commit 553bcd5.

* Revert "Add arguments for codecov upload action"

This reverts commit dff18e5.

---------

Co-authored-by: acolytec3 <[email protected]>
Co-authored-by: Holger Drewes <[email protected]>

Author: 3 people

.github/workflows/genesis-build.yml

@@ -39,4 +39,11 @@ jobs:
         working-directory: ${{github.workspace}}
 
       - run: npm run lint
+      
+      - run: npm run coverage
+      - uses: codecov/codecov-action@v3
+        with:
+          files: ${{ env.cwd }}/coverage/lcov.info
+          flags: genesis
+
       - run: npm run test:node # Only run node tests for now until vitest browser test issues are sorted out

.github/workflows/rlp-build.yml

@@ -38,3 +38,8 @@ jobs:
 
       - run: npm run lint
 
+      - run: npm run coverage
+      - uses: codecov/codecov-action@v3
+        with:
+          files: ${{ env.cwd }}/coverage/lcov.info
+          flags: rlp

.github/workflows/wallet-build.yml

@@ -39,4 +39,11 @@ jobs:
         working-directory: ${{github.workspace}}
 
       - run: npm run lint
+
+      - run: npm run coverage
+      - uses: codecov/codecov-action@v3
+        with:
+          files: ${{ env.cwd }}/coverage/lcov.info
+          flags: wallet
+
       - run: npm run test:node # Only run node tests for now until vitest browser test issues are sorted out

packages/ethash/package.json

@@ -33,7 +33,7 @@
   "scripts": {
     "build": "../../config/cli/ts-build.sh",
     "clean": "../../config/cli/clean-package.sh",
-    "coverage": "DEBUG=ethjs npx vitest run --coverage.enabled --coverage.reporter=lcov",
+    "coverage": "../../config/cli/coverage.sh",
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "ts-node ../../scripts/examples-runner.ts -- ethash",
     "lint": "../../config/cli/lint.sh",

packages/rlp/package.json

@@ -44,7 +44,7 @@
   "scripts": {
     "build": "../../config/cli/ts-build.sh node",
     "clean": "../../config/cli/clean-package.sh",
-    "coverage": "DEBUG=ethjs npx vitest run --coverage.enabled --coverage.reporter=lcov",
+    "coverage": "c8 --all --reporter=lcov --reporter=text npm run test:node",
     "examples": "ts-node ../../scripts/examples-runner.ts -- rlp",
     "lint": "../../config/cli/lint.sh",
     "lint:diff": "../../config/cli/lint-diff.sh",

packages/wallet/package.json

@@ -33,7 +33,7 @@
   "scripts": {
     "build": "../../config/cli/ts-build.sh",
     "clean": "../../config/cli/clean-package.sh",
-    "coverage": "npm run build && nyc --reporter=lcov npm run test:unit",
+    "coverage": "c8 --all --reporter=lcov --reporter=text npm run test:node",
     "docs:build": "npx typedoc --options typedoc.cjs",
     "examples": "ts-node ../../scripts/examples-runner.ts -- wallet",
     "lint": "../../config/cli/lint.sh",

packages/wallet/test/hdkey.spec.ts

@@ -16,7 +16,7 @@ describe('HD Key tests', () => {
     assert.doesNotThrow(function () {
       EthereumHDKey.fromMasterSeed(fixtureseed)
     })
-  })
+  }, 30000)
 
   it('.fromMnemonic()', () => {
     const path = "m/44'/60'/0'/0/0"
@@ -25,21 +25,21 @@ describe('HD Key tests', () => {
 
     assert.strictEqual(wallet.getPrivateKeyString(), fixturePrivateKey)
     assert.strictEqual(wallet.getAddressString(), fixtureAddress)
-  })
+  }, 30000)
 
   it('.privateExtendedKey()', () => {
     assert.deepEqual(
       fixturehd.privateExtendedKey(),
       'xprv9s21ZrQH143K4KqQx9Zrf1eN8EaPQVFxM2Ast8mdHn7GKiDWzNEyNdduJhWXToy8MpkGcKjxeFWd8oBSvsz4PCYamxR7TX49pSpp3bmHVAY'
     )
-  })
+  }, 30000)
 
   it('.publicExtendedKey()', () => {
     assert.deepEqual(
       fixturehd.publicExtendedKey(),
       'xpub661MyMwAqRbcGout4B6s29b6gGQsowyoiF6UgXBEr7eFCWYfXuZDvRxP9zEh1Kwq3TLqDQMbkbaRpSnoC28oWvjLeshoQz1StZ9YHM1EpcJ'
     )
-  })
+  }, 30000)
 
   it('.fromExtendedKey()', () => {
     const onlyPublicExtendedKey = EthereumHDKey.fromExtendedKey(
@@ -69,15 +69,15 @@ describe('HD Key tests', () => {
       'xprv9s21ZrQH143K4KqQx9Zrf1eN8EaPQVFxM2Ast8mdHn7GKiDWzNEyNdduJhWXToy8MpkGcKjxeFWd8oBSvsz4PCYamxR7TX49pSpp3bmHVAY',
       'successfully generated key from extended private key'
     )
-  })
+  }, 30000)
 
   it('.deriveChild()', () => {
     const hdnode = fixturehd.deriveChild(1)
     assert.deepEqual(
       hdnode.privateExtendedKey(),
       'xprv9vYSvrg3eR5FaKbQE4Ao2vHdyvfFL27aWMyH6X818mKWMsqqQZAN6HmRqYDGDPLArzaqbLExRsxFwtx2B2X2QKkC9uoKsiBNi22tLPKZHNS'
     )
-  })
+  }, 30000)
 
   it('.derivePath()', () => {
     const hdnode1 = fixturehd.derivePath('m')
@@ -92,7 +92,7 @@ describe('HD Key tests', () => {
       'xprvA1ErCzsuXhpB8iDTsbmgpkA2P8ggu97hMZbAXTZCdGYeaUrDhyR8fEw47BNEgLExsWCVzFYuGyeDZJLiFJ9kwBzGojQ6NB718tjVJrVBSrG',
       "should work with m/44'/0'/0/1"
     )
-  })
+  }, 30000)
 
   it('.getWallet()', () => {
     assert.deepEqual(
@@ -114,5 +114,5 @@ describe('HD Key tests', () => {
       '0x0639797f6cc72aea0f3d309730844a9e67d9f1866e55845c5f7e0ab48402973defa5cb69df462bcc6d73c31e1c663c225650e80ef14a507b203f2a12aea55bc1',
       'should work with public nodes'
     )
-  })
+  }, 30000)
 })