util, devp2p -> monorepo transition: removed devp2p tsconfig.browser.json (build breaking, needs to be fixed), fixed linting

Author: holgerd77

packages/devp2p/tsconfig.browser.json

@@ -96,6 +96,9 @@
     "@types/node": "^11.13.4",
     "@types/secp256k1": "^4.0.1",
     "@types/tape": "^4.13.0",
+    "eslint": "^6.8.0",
+    "eslint-config-prettier": "^6.11.0",
+    "eslint-plugin-implicit-dependencies": "^1.0.4",
     "karma": "^5.2.1",
     "karma-chrome-launcher": "^3.1.0",
     "karma-firefox-launcher": "^1.3.0",

packages/util/package.json

@@ -5,7 +5,7 @@ import {
   privateKeyVerify,
   publicKeyCreate,
   publicKeyVerify,
-  publicKeyConvert
+  publicKeyConvert,
 } from 'ethereum-cryptography/secp256k1'
 import { stripHexPrefix } from 'ethjs-util'
 import { KECCAK256_RLP, KECCAK256_NULL } from './constants'
@@ -121,7 +121,7 @@ export class Account {
 /**
  * Checks if the address is a valid. Accepts checksummed addresses too.
  */
-export const isValidAddress = function(hexAddress: string): boolean {
+export const isValidAddress = function (hexAddress: string): boolean {
   assertIsHexString(hexAddress)
   return /^0x[0-9a-fA-F]{40}$/.test(hexAddress)
 }
@@ -136,7 +136,7 @@ export const isValidAddress = function(hexAddress: string): boolean {
  * WARNING: Checksums with and without the chainId will differ. As of 2019-06-26, the most commonly
  * used variation in Ethereum was without the chainId. This may change in the future.
  */
-export const toChecksumAddress = function(hexAddress: string, eip1191ChainId?: BNLike): string {
+export const toChecksumAddress = function (hexAddress: string, eip1191ChainId?: BNLike): string {
   assertIsHexString(hexAddress)
   const address = stripHexPrefix(hexAddress).toLowerCase()
 
@@ -165,7 +165,7 @@ export const toChecksumAddress = function(hexAddress: string, eip1191ChainId?: B
  *
  * See toChecksumAddress' documentation for details about the eip1191ChainId parameter.
  */
-export const isValidChecksumAddress = function(
+export const isValidChecksumAddress = function (
   hexAddress: string,
   eip1191ChainId?: BNLike
 ): boolean {
@@ -177,7 +177,7 @@ export const isValidChecksumAddress = function(
  * @param from The address which is creating this new address
  * @param nonce The nonce of the from account
  */
-export const generateAddress = function(from: Buffer, nonce: Buffer): Buffer {
+export const generateAddress = function (from: Buffer, nonce: Buffer): Buffer {
   assertIsBuffer(from)
   assertIsBuffer(nonce)
   const nonceBN = new BN(nonce)
@@ -198,7 +198,7 @@ export const generateAddress = function(from: Buffer, nonce: Buffer): Buffer {
  * @param salt A salt
  * @param initCode The init code of the contract being created
  */
-export const generateAddress2 = function(from: Buffer, salt: Buffer, initCode: Buffer): Buffer {
+export const generateAddress2 = function (from: Buffer, salt: Buffer, initCode: Buffer): Buffer {
   assertIsBuffer(from)
   assertIsBuffer(salt)
   assertIsBuffer(initCode)
@@ -216,7 +216,7 @@ export const generateAddress2 = function(from: Buffer, salt: Buffer, initCode: B
 /**
  * Checks if the private key satisfies the rules of the curve secp256k1.
  */
-export const isValidPrivate = function(privateKey: Buffer): boolean {
+export const isValidPrivate = function (privateKey: Buffer): boolean {
   return privateKeyVerify(privateKey)
 }
 
@@ -226,7 +226,7 @@ export const isValidPrivate = function(privateKey: Buffer): boolean {
  * @param publicKey The two points of an uncompressed key, unless sanitize is enabled
  * @param sanitize Accept public keys in other formats
  */
-export const isValidPublic = function(publicKey: Buffer, sanitize: boolean = false): boolean {
+export const isValidPublic = function (publicKey: Buffer, sanitize: boolean = false): boolean {
   assertIsBuffer(publicKey)
   if (publicKey.length === 64) {
     // Convert to SEC1 for secp256k1
@@ -246,7 +246,7 @@ export const isValidPublic = function(publicKey: Buffer, sanitize: boolean = fal
  * @param pubKey The two points of an uncompressed key, unless sanitize is enabled
  * @param sanitize Accept public keys in other formats
  */
-export const pubToAddress = function(pubKey: Buffer, sanitize: boolean = false): Buffer {
+export const pubToAddress = function (pubKey: Buffer, sanitize: boolean = false): Buffer {
   assertIsBuffer(pubKey)
   if (sanitize && pubKey.length !== 64) {
     pubKey = Buffer.from(publicKeyConvert(pubKey, false).slice(1))
@@ -261,7 +261,7 @@ export const publicToAddress = pubToAddress
  * Returns the ethereum public key of a given private key.
  * @param privateKey A private key must be 256 bits wide
  */
-export const privateToPublic = function(privateKey: Buffer): Buffer {
+export const privateToPublic = function (privateKey: Buffer): Buffer {
   assertIsBuffer(privateKey)
   // skip the type flag and use the X, Y points
   return Buffer.from(publicKeyCreate(privateKey, false)).slice(1)
@@ -271,14 +271,14 @@ export const privateToPublic = function(privateKey: Buffer): Buffer {
  * Returns the ethereum address of a given private key.
  * @param privateKey A private key must be 256 bits wide
  */
-export const privateToAddress = function(privateKey: Buffer): Buffer {
+export const privateToAddress = function (privateKey: Buffer): Buffer {
   return publicToAddress(privateToPublic(privateKey))
 }
 
 /**
  * Converts a public key to the Ethereum format.
  */
-export const importPublic = function(publicKey: Buffer): Buffer {
+export const importPublic = function (publicKey: Buffer): Buffer {
   assertIsBuffer(publicKey)
   if (publicKey.length !== 64) {
     publicKey = Buffer.from(publicKeyConvert(publicKey, false).slice(1))
@@ -289,7 +289,7 @@ export const importPublic = function(publicKey: Buffer): Buffer {
 /**
  * Returns the zero address.
  */
-export const zeroAddress = function(): string {
+export const zeroAddress = function (): string {
   const addressLength = 20
   const addr = zeros(addressLength)
   return bufferToHex(addr)
@@ -298,7 +298,7 @@ export const zeroAddress = function(): string {
 /**
  * Checks if a given address is the zero address.
  */
-export const isZeroAddress = function(hexAddress: string): boolean {
+export const isZeroAddress = function (hexAddress: string): boolean {
   assertIsHexString(hexAddress)
   const zeroAddr = zeroAddress()
   return zeroAddr === hexAddress

packages/util/src/account.ts

@@ -6,7 +6,7 @@ import {
   pubToAddress,
   privateToAddress,
   generateAddress,
-  generateAddress2
+  generateAddress2,
 } from './account'
 
 export class Address {

packages/util/src/address.ts

@@ -7,7 +7,7 @@ import { assertIsBuffer, assertIsArray, assertIsHexString } from './helpers'
  * Returns a buffer filled with 0s.
  * @param bytes the number of bytes the buffer should be
  */
-export const zeros = function(bytes: number): Buffer {
+export const zeros = function (bytes: number): Buffer {
   return Buffer.allocUnsafe(bytes).fill(0)
 }
 
@@ -19,7 +19,7 @@ export const zeros = function(bytes: number): Buffer {
  * @param right whether to start padding form the left or right
  * @return (Buffer)
  */
-const setLength = function(msg: Buffer, length: number, right: boolean) {
+const setLength = function (msg: Buffer, length: number, right: boolean) {
   const buf = zeros(length)
   if (right) {
     if (msg.length < length) {
@@ -43,7 +43,7 @@ const setLength = function(msg: Buffer, length: number, right: boolean) {
  * @param length the number of bytes the output should be
  * @return (Buffer)
  */
-export const setLengthLeft = function(msg: Buffer, length: number) {
+export const setLengthLeft = function (msg: Buffer, length: number) {
   assertIsBuffer(msg)
   return setLength(msg, length, false)
 }
@@ -55,7 +55,7 @@ export const setLengthLeft = function(msg: Buffer, length: number) {
  * @param length the number of bytes the output should be
  * @return (Buffer)
  */
-export const setLengthRight = function(msg: Buffer, length: number) {
+export const setLengthRight = function (msg: Buffer, length: number) {
   assertIsBuffer(msg)
   return setLength(msg, length, true)
 }
@@ -65,7 +65,7 @@ export const setLengthRight = function(msg: Buffer, length: number) {
  * @param a (Buffer|Array|String)
  * @return (Buffer|Array|String)
  */
-const stripZeros = function(a: any): Buffer | number[] | string {
+const stripZeros = function (a: any): Buffer | number[] | string {
   let first = a[0]
   while (a.length > 0 && first.toString() === '0') {
     a = a.slice(1)
@@ -79,7 +79,7 @@ const stripZeros = function(a: any): Buffer | number[] | string {
  * @param a (Buffer)
  * @return (Buffer)
  */
-export const unpadBuffer = function(a: Buffer): Buffer {
+export const unpadBuffer = function (a: Buffer): Buffer {
   assertIsBuffer(a)
   return stripZeros(a) as Buffer
 }
@@ -89,7 +89,7 @@ export const unpadBuffer = function(a: Buffer): Buffer {
  * @param a (number[])
  * @return (number[])
  */
-export const unpadArray = function(a: number[]): number[] {
+export const unpadArray = function (a: number[]): number[] {
   assertIsArray(a)
   return stripZeros(a) as number[]
 }
@@ -99,7 +99,7 @@ export const unpadArray = function(a: number[]): number[] {
  * @param a (String)
  * @return (String)
  */
-export const unpadHexString = function(a: string): string {
+export const unpadHexString = function (a: string): string {
   assertIsHexString(a)
   a = stripHexPrefix(a)
   return stripZeros(a) as string
@@ -122,7 +122,7 @@ export type ToBufferInputTypes =
  * Inputs supported: `Buffer`, `String`, `Number`, null/undefined, `BN` and other objects with a `toArray()` or `toBuffer()` method.
  * @param v the value
  */
-export const toBuffer = function(v: ToBufferInputTypes): Buffer {
+export const toBuffer = function (v: ToBufferInputTypes): Buffer {
   if (v === null || v === undefined) {
     return Buffer.allocUnsafe(0)
   }
@@ -169,15 +169,15 @@ export const toBuffer = function(v: ToBufferInputTypes): Buffer {
  * @param buf `Buffer` object to convert
  * @throws If the input number exceeds 53 bits.
  */
-export const bufferToInt = function(buf: Buffer): number {
+export const bufferToInt = function (buf: Buffer): number {
   return new BN(toBuffer(buf)).toNumber()
 }
 
 /**
  * Converts a `Buffer` into a `0x`-prefixed hex `String`.
  * @param buf `Buffer` object to convert
  */
-export const bufferToHex = function(buf: Buffer): string {
+export const bufferToHex = function (buf: Buffer): string {
   buf = toBuffer(buf)
   return '0x' + buf.toString('hex')
 }
@@ -186,22 +186,22 @@ export const bufferToHex = function(buf: Buffer): string {
  * Interprets a `Buffer` as a signed integer and returns a `BN`. Assumes 256-bit numbers.
  * @param num Signed integer value
  */
-export const fromSigned = function(num: Buffer): BN {
+export const fromSigned = function (num: Buffer): BN {
   return new BN(num).fromTwos(256)
 }
 
 /**
  * Converts a `BN` to an unsigned integer and returns it as a `Buffer`. Assumes 256-bit numbers.
  * @param num
  */
-export const toUnsigned = function(num: BN): Buffer {
+export const toUnsigned = function (num: BN): Buffer {
   return Buffer.from(num.toTwos(256).toArray())
 }
 
 /**
  * Adds "0x" to a given `String` if it does not already start with "0x".
  */
-export const addHexPrefix = function(str: string): string {
+export const addHexPrefix = function (str: string): string {
   if (typeof str !== 'string') {
     return str
   }
@@ -214,7 +214,7 @@ export const addHexPrefix = function(str: string): string {
  * @param ba (Buffer|Array)
  * @return (Array|String|null)
  */
-export const baToJSON = function(ba: any): any {
+export const baToJSON = function (ba: any): any {
   if (Buffer.isBuffer(ba)) {
     return `0x${ba.toString('hex')}`
   } else if (ba instanceof Array) {