change usage from fromRlpSerializedTx to fromSerializedTx

Author: ryanio

packages/tx/examples/ropsten-tx.ts

@@ -7,7 +7,7 @@ const txData = toBuffer(
 )
 
 const common = new Common({ chain: 'ropsten', hardfork: 'petersburg' })
-const tx = Transaction.fromRlpSerializedTx(txData, { common })
+const tx = Transaction.fromSerializedTx(txData, { common })
 
 if (
   tx.validate() &&

packages/tx/src/eip2930Transaction.ts

@@ -82,12 +82,12 @@ export default class AccessListEIP2930Transaction extends BaseTransaction<Access
 
   /**
    * Instantiate a transaction from the serialized tx.
-   * (alias of fromSerializedTx())
+   * (alias of `fromSerializedTx()`)
    *
    * Note: This means that the Buffer should start with 0x01.
    *
    * @deprecated this constructor alias is deprecated and will be removed
-   * in favor of the from SerializedTx() constructor
+   * in favor of the `fromSerializedTx() constructor
    */
   public static fromRlpSerializedTx(serialized: Buffer, opts: TxOptions = {}) {
     return AccessListEIP2930Transaction.fromSerializedTx(serialized, opts)

packages/tx/src/legacyTransaction.ts

@@ -42,10 +42,10 @@ export default class Transaction extends BaseTransaction<Transaction> {
 
   /**
    * Instantiate a transaction from the serialized tx.
-   * (alias of fromSerializedTx())
+   * (alias of `fromSerializedTx()`)
    *
    * @deprecated this constructor alias is deprecated and will be removed
-   * in favor of the from SerializedTx() constructor
+   * in favor of the `fromSerializedTx()` constructor
    */
   public static fromRlpSerializedTx(serialized: Buffer, opts: TxOptions = {}) {
     return Transaction.fromSerializedTx(serialized, opts)

packages/tx/src/transactionFactory.ts

@@ -63,9 +63,9 @@ export default class TransactionFactory {
         )
       }
 
-      return AccessListEIP2930Transaction.fromRlpSerializedTx(rawData, txOptions)
+      return AccessListEIP2930Transaction.fromSerializedTx(rawData, txOptions)
     } else {
-      return Transaction.fromRlpSerializedTx(rawData, txOptions)
+      return Transaction.fromSerializedTx(rawData, txOptions)
     }
   }
 

packages/tx/test/base.spec.ts

@@ -80,10 +80,10 @@ tape('[BaseTransaction]', function (t) {
       tx = txType.class.fromTxData({}, { common, freeze: false })
       const rlpData = tx.serialize()
 
-      tx = txType.class.fromRlpSerializedTx(rlpData, { common })
+      tx = txType.class.fromSerializedTx(rlpData, { common })
       st.ok(Object.isFrozen(tx), `${txType.name}: tx should be frozen by default`)
 
-      tx = txType.class.fromRlpSerializedTx(rlpData, { common, freeze: false })
+      tx = txType.class.fromSerializedTx(rlpData, { common, freeze: false })
       st.ok(
         !Object.isFrozen(tx),
         `${txType.name}: tx should not be frozen when freeze deactivated in options`
@@ -105,12 +105,12 @@ tape('[BaseTransaction]', function (t) {
     for (const txType of txTypes) {
       txType.txs.forEach(function (tx: any) {
         st.ok(
-          txType.class.fromRlpSerializedTx(tx.serialize(), { common }),
-          `${txType.name}: should do roundtrip serialize() -> fromRlpSerializedTx()`
+          txType.class.fromSerializedTx(tx.serialize(), { common }),
+          `${txType.name}: should do roundtrip serialize() -> fromSerializedTx()`
         )
         st.ok(
           txType.class.fromSerializedTx(tx.serialize(), { common }),
-          `${txType.name}: should do roundtrip serialize() -> fromRlpSerializedTx()`
+          `${txType.name}: should do roundtrip serialize() -> fromSerializedTx()`
         )
       })
     }

packages/tx/test/legacy.spec.ts

@@ -55,7 +55,7 @@ tape('[Transaction]', function (t) {
       const privKey = Buffer.from(txFixtures[0].privateKey, 'hex')
       tx = tx.sign(privKey)
       const serialized = tx.serialize()
-      st.throws(() => Transaction.fromRlpSerializedTx(serialized))
+      st.throws(() => Transaction.fromSerializedTx(serialized))
       st.end()
     }
   )
@@ -131,7 +131,7 @@ tape('[Transaction]', function (t) {
     const s1 = tx.serialize()
 
     const s1Rlp = toBuffer('0x' + s1.toString('hex'))
-    const tx2 = Transaction.fromRlpSerializedTx(s1Rlp)
+    const tx2 = Transaction.fromSerializedTx(s1Rlp)
     const s2 = tx2.serialize()
 
     st.ok(s1.equals(s2))
@@ -182,7 +182,7 @@ tape('[Transaction]', function (t) {
     "getMessageToSign(), getSenderPublicKey() (implicit call) -> verify EIP155 signature based on Vitalik's tests",
     function (st) {
       txFixturesEip155.forEach(function (tx) {
-        const pt = Transaction.fromRlpSerializedTx(toBuffer(tx.rlp))
+        const pt = Transaction.fromSerializedTx(toBuffer(tx.rlp))
         st.equal(pt.getMessageToSign().toString('hex'), tx.hash)
         st.equal('0x' + pt.serialize().toString('hex'), tx.rlp)
         st.equal(pt.getSenderAddress().toString(), '0x' + tx.sender)
@@ -359,7 +359,7 @@ tape('[Transaction]', function (t) {
 
     const serialized = tx.serialize()
 
-    const reTx = Transaction.fromRlpSerializedTx(serialized, { common })
+    const reTx = Transaction.fromSerializedTx(serialized, { common })
     st.equal(reTx.verifySignature(), true)
     st.equal(reTx.common.chainId(), 42)
 
@@ -394,11 +394,11 @@ tape('[Transaction]', function (t) {
     const rawSigned = tx.serialize()
     st.ok(tx.isSigned())
 
-    tx = Transaction.fromRlpSerializedTx(rawUnsigned)
+    tx = Transaction.fromSerializedTx(rawUnsigned)
     st.notOk(tx.isSigned())
     tx = tx.sign(privateKey)
     st.ok(tx.isSigned())
-    tx = Transaction.fromRlpSerializedTx(rawSigned)
+    tx = Transaction.fromSerializedTx(rawSigned)
     st.ok(tx.isSigned())
 
     const signedValues = (rlp.decode(rawSigned) as any) as Buffer[]

packages/tx/test/transactionRunner.ts

@@ -46,7 +46,7 @@ tape('TransactionTests', (t) => {
               const rawTx = toBuffer(testData.rlp)
               const hardfork = forkNameMap[forkName]
               const common = new Common({ chain: 1, hardfork })
-              const tx = Transaction.fromRlpSerializedTx(rawTx, { common })
+              const tx = Transaction.fromSerializedTx(rawTx, { common })
 
               const sender = tx.getSenderAddress().toString()
               const hash = tx.hash().toString('hex')