devp2p -> DPT: fixed undefined array access in ETH._getStatusString() on malformed ETH/64 status msgs (triggered in client runs)

Author: holgerd77

packages/devp2p/src/dpt/ban-list.ts

@@ -13,14 +13,14 @@ export class BanList {
     this.lru = new LRUCache({ max: 30000 }) // 10k should be enough (each peer obj can has 3 keys)
   }
 
-  add(obj: string | Buffer | PeerInfo, maxAge?: number) {
+  add(obj: string | Buffer | PeerInfo, maxAge?: number) {
     for (const key of KBucket.getKeys(obj)) {
       this.lru.set(key, true, maxAge)
       debug(`Added peer ${formatLogId(key, verbose)}, size: ${this.lru.length}`)
     }
   }
 
-  has(obj: string | Buffer | PeerInfo): boolean {
+  has(obj: string | Buffer | PeerInfo): boolean {
     return KBucket.getKeys(obj).some((key: string) => Boolean(this.lru.get(key)))
   }
 }

packages/devp2p/src/eth/index.ts

@@ -182,8 +182,8 @@ export class ETH extends EventEmitter {
       verbose
     )}`
     if (this._version >= 64) {
-      sStr += `, ForkHash: 0x${(status[5][0] as Buffer).toString('hex')}`
-      sStr += `, ForkNext: ${buffer2int(status[5][1] as Buffer)}`
+      sStr += `, ForkHash: 0x${status[5] ? '0x' + (status[5][0] as Buffer).toString('hex') : '-'}`
+      sStr += `, ForkNext: ${status[5] ? buffer2int(status[5][1] as Buffer) : '-'}`
     }
     sStr += `]`
     return sStr