monorepo: add tsc to ci (#3661)

* monorepo: add tsc to ci

* monorepo: attempt fixing yml config

* add tsc / typecheck to ci

* add eth-tests step

* fix type issues

* remove extraneous file

* update vitest to 2.1

* add submodule key to typecheck job

* more ci fixes

* add proper return value

---------

Co-authored-by: Jochem Brouwer <[email protected]>
Co-authored-by: acolytec3 <[email protected]>

Author: 3 people

.github/workflows/build.yml

@@ -194,4 +194,12 @@ jobs:
     uses: ./.github/workflows/lint.yml
     with:
       dep-cache-key: ${{ needs.build.outputs.dep-cache-key }}
-      
+
+  typecheck:
+    needs: [build, checkout-submodules]
+    uses: ./.github/workflows/typecheck.yml
+    with:
+      dep-cache-key: ${{ needs.build.outputs.dep-cache-key }}
+      submodule-cache-key: ${{ needs.checkout-submodules.outputs.submodule-cache-key }}
+
+  

.github/workflows/typecheck.yml

@@ -0,0 +1,62 @@
+name: Typecheck (tsc)
+on:
+  workflow_call:
+    inputs:
+      dep-cache-key:
+        required: true
+        type: string
+      submodule-cache-key:
+        required: true
+        type: string
+  workflow_dispatch:
+    inputs:
+      dep-cache-key:
+        required: false
+        default: 'none'
+      submodule-cache-key:
+        required: false
+        default: 'none'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}-typecheck
+  cancel-in-progress: true
+
+jobs:
+  typecheck:
+    runs-on: ubuntu-latest
+    steps:
+      # We clone the repo and submodules if triggered from work-flow dispatch
+      - if: inputs.submodule-cache-key == 'none'
+        uses: actions/checkout@v4
+
+      # We restore the code/deps from cache if triggered from workflow_call (i.e. have valid cache key)
+      - if: inputs.dep-cache-key != 'none' 
+        uses: actions/cache/restore@v4
+        id: dep-cache
+        with:
+          path: ${{github.workspace}}
+          key: ${{ inputs.dep-cache-key }}
+  
+      - name: Use Node.js 20
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: 'npm'
+
+      - name: Install Dependencies (if not restored from cache)
+        if: steps.dep-cache.outputs.cache-hit != 'true'
+        run: npm ci     
+        working-directory: ${{ github.workspace }}
+
+      - if: inputs.submodule-cache-key != 'none'
+        uses: actions/cache/restore@v4
+        name: Initialize ethereum-tests
+        id: submodules-cache
+        with:
+          path: ${{github.workspace}}/packages/ethereum-tests
+          key: ${{ inputs.submodule-cache-key}}
+          fail-on-cache-miss: true
+            
+   
+      - run: npm run tsc --workspaces
+        working-directory: ${{ github.workspace }}