tx -> EIP-2930: set default HF from common to berlin, small fixes

Author: holgerd77

packages/tx/src/baseTransaction.ts

@@ -36,15 +36,15 @@ export abstract class BaseTransaction<TransactionObject> {
       value: this.value,
     }
 
-    this.validateExcdeedsMaxInteger(validateCannotExceedMaxInteger)
+    this.validateExceedsMaxInteger(validateCannotExceedMaxInteger)
 
     this.common =
       (txOptions.common &&
         Object.assign(Object.create(Object.getPrototypeOf(txOptions.common)), txOptions.common)) ??
       DEFAULT_COMMON
   }
 
-  protected validateExcdeedsMaxInteger(validateCannotExceedMaxInteger: { [key: string]: BN }) {
+  protected validateExceedsMaxInteger(validateCannotExceedMaxInteger: { [key: string]: BN }) {
     for (const [key, value] of Object.entries(validateCannotExceedMaxInteger)) {
       if (value && value.gt(MAX_INTEGER)) {
         throw new Error(`${key} cannot exceed MAX_INTEGER, given ${value}`)

packages/tx/src/legacyTransaction.ts

@@ -101,7 +101,7 @@ export default class LegacyTransaction extends BaseTransaction<LegacyTransaction
       s: this.s ?? new BN(0),
     }
 
-    this.validateExcdeedsMaxInteger(validateCannotExceedMaxInteger)
+    this.validateExceedsMaxInteger(validateCannotExceedMaxInteger)
 
     if (this.v) {
       this._validateTxV(this.v)

packages/tx/src/types.ts

@@ -183,4 +183,4 @@ export interface JsonTx {
   type?: string
 }
 
-export const DEFAULT_COMMON = new Common({ chain: 'mainnet' })
+export const DEFAULT_COMMON = new Common({ chain: 'mainnet', hardfork: 'berlin' })

packages/tx/test/api.spec.ts

@@ -21,7 +21,7 @@ tape('[Transaction]: Basic functions', function (t) {
 
   t.test('should initialize correctly', function (st) {
     let tx = LegacyTransaction.fromTxData({})
-    st.equal(tx.common.hardfork(), 'istanbul', 'should initialize with correct default HF')
+    st.equal(tx.common.hardfork(), 'berlin', 'should initialize with correct default HF')
     st.ok(Object.isFrozen(tx), 'tx should be frozen by default')
 
     const common = new Common({ chain: 'mainnet', hardfork: 'spuriousDragon' })