No more unerasable syntax (#3972)

acolytec3 · holgerd77 · gabrocheleau · web-flow · commit 4c50c51da050 · 2025-04-14T12:04:25.000+02:00
* Remove all angle bracket type casting

* Add new erasableSyntax job

* rename ci job

* add push trigger

* add keys for `push`

* remove angle brackets

* skip build step

* try to execute a block

* Fix script

* AI thinks this is more clever

* redo script

* Remove unerasable syntax

* fix CI and testdata exports map

* clean up ci job

* Update .github/workflows/noCompile.yml

Co-authored-by: Gabriel Rocheleau &lt;contact@rockwaterweb.com&gt;

---------

Co-authored-by: Holger Drewes &lt;Holger.Drewes@gmail.com&gt;
Co-authored-by: Gabriel Rocheleau &lt;contact@rockwaterweb.com&gt;
diff --git a/.github/workflows/noCompile.yml b/.github/workflows/noCompile.yml
@@ -0,0 +1,49 @@
+name: NoCompile
+on:
+  workflow_call:
+    inputs:
+      dep-cache-key:
+        required: true
+        type: string
+  workflow_dispatch:
+    inputs:
+      dep-cache-key:
+        required: false
+        default: 'none'
+  push:
+    branches:
+      - master
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}-noCompile
+  cancel-in-progress: true
+
+jobs:
+  test-nocompile:
+    runs-on: ubuntu-latest
+    # Set default values for cache keys when triggered by push
+    env:
+      DEP_CACHE_KEY: ${{ github.event_name == 'push' && 'none' || inputs.dep-cache-key }}
+    
+    steps:
+      # We restore the code/deps from cache if triggered from workflow_call (i.e. have valid cache key)
+      - if: env.DEP_CACHE_KEY != 'none' 
+        uses: actions/cache/restore@v4
+        id: dep-cache
+        with:
+          path: ${{github.workspace}}
+          key: ${{ env.DEP_CACHE_KEY }}
+  
+      - name: Use Node.js 23
+        uses: actions/setup-node@v4
+        with:
+          node-version: 23
+          cache: 'npm'
+
+      - name: Install Dependencies (if not restored from cache)
+        if: steps.dep-cache.outputs.cache-hit != 'true'
+        run: npm ci --ignore-scripts  
+        working-directory: ${{ github.workspace }}
+    
+      - run: node --conditions=typescript --experimental-strip-types examples/inlineClient.ts
+        working-directory: ${{ github.workspace }}/packages/client
diff --git a/packages/client/examples/inlineClient.ts b/packages/client/examples/inlineClient.ts
@@ -0,0 +1,19 @@
+import { createCommonFromGethGenesis } from '@ethereumjs/common'
+import { eip4844GethGenesis } from '@ethereumjs/testdata'
+import { Config } from '../src/config.ts'
+import { createInlineClient } from '../src/util/inclineClient.ts'
+
+const main = async () => {
+  const client = await createInlineClient(
+    new Config({}),
+    createCommonFromGethGenesis(eip4844GethGenesis, {}),
+    {},
+    undefined,
+    true,
+  )
+  await client.start()
+  await client.stop()
+  process.exit(0)
+}
+
+main()
diff --git a/packages/client/src/net/peer/peer.ts b/packages/client/src/net/peer/peer.ts
@@ -170,12 +170,12 @@ export abstract class Peer extends EventEmitter {
 
       await bound!.handshake(sender)
 
-      this.eth = <BoundEthProtocol>bound
+      this.eth = bound as BoundEthProtocol
     } else if (protocol.name === 'snap') {
       bound = new BoundSnapProtocol(boundOpts)
       if (sender.status === undefined) throw Error('Snap can only be bound on handshaked peer')
 
-      this.snap = <BoundSnapProtocol>bound
+      this.snap = bound as BoundSnapProtocol
     } else {
       throw EthereumJSErrorWithoutCode(`addProtocol: ${protocol.name} protocol not supported`)
     }
diff --git a/packages/client/src/sync/fetcher/fetcher.ts b/packages/client/src/sync/fetcher/fetcher.ts
@@ -483,7 +483,7 @@ export abstract class Fetcher<JobTask, JobResult, StorageItem> extends Readable
         many: { chunk: Job<JobTask, JobResult, StorageItem>; encoding: string }[],
         cb: Function,
       ) => {
-        const items = (<Job<JobTask, JobResult, StorageItem>[]>[]).concat(
+        const items = ([] as Job<JobTask, JobResult, StorageItem>[]).concat(
           ...many.map(
             (x: { chunk: Job<JobTask, JobResult, StorageItem>; encoding: string }) => x.chunk,
           ),
diff --git a/packages/client/test/sync/beaconsync.spec.ts b/packages/client/test/sync/beaconsync.spec.ts
@@ -120,7 +120,7 @@ describe('[BeaconSynchronizer]', async () => {
     /// @ts-expect-error -- Assigning simpler config for testing
     sync.pool = { peers }
     sync['forceSync'] = true
-    assert.equal(await sync.best(), <any>peers[1], 'found best')
+    assert.equal(await sync.best(), peers[1] as any, 'found best')
     await sync.stop()
     await sync.close()
   })
diff --git a/packages/client/test/sync/fetcher/fetcher.spec.ts b/packages/client/test/sync/fetcher/fetcher.spec.ts
@@ -76,7 +76,7 @@ describe('should handle expiration', async () => {
     })
 
     fetcher['in'].insert(job as any)
-    ;(<any>fetcher)['_readableState'] = []
+    ;(fetcher as any)['_readableState'] = []
     fetcher['running'] = true
     fetcher['total'] = 10
     fetcher.next()
diff --git a/packages/ethash/src/index.ts b/packages/ethash/src/index.ts
@@ -93,12 +93,12 @@ export class Miner {
 
     if (solution) {
       if (this.block) {
-        const data = <BlockData>this.block.toJSON()
+        const data = this.block.toJSON() as BlockData
         data.header!.mixHash = solution.mixHash
         data.header!.nonce = solution.nonce
         return createBlock(data, { common: this.block.common })
       } else {
-        const data = <HeaderData>this.blockHeader.toJSON()
+        const data = this.blockHeader.toJSON() as HeaderData
         data.mixHash = solution.mixHash
         data.nonce = solution.nonce
         return createBlockHeader(data, { common: this.blockHeader.common })
diff --git a/packages/ethash/test/miner.spec.ts b/packages/ethash/test/miner.spec.ts
@@ -65,15 +65,15 @@ describe('Miner', () => {
       { common },
     )
     const miner = e.getMiner(block.header)
-    const solution = <BlockHeader>await miner.mine(-1)
+    const solution = (await miner.mine(-1)) as BlockHeader
 
     assert.isTrue(
       await e.verifyPOW(createBlock({ header: solution.toJSON() }, { common })),
       'successfully mined block',
     )
 
     const blockMiner = e.getMiner(block)
-    const blockSolution = <Block>await blockMiner.mine(-1)
+    const blockSolution = (await blockMiner.mine(-1)) as Block
 
     assert.isTrue(await e.verifyPOW(blockSolution))
   }, 60000)
@@ -129,13 +129,13 @@ describe('Miner', () => {
     )
 
     const miner = e.getMiner(block.header)
-    const solution = <BlockHeader>await miner.mine(-1)
+    const solution = (await miner.mine(-1)) as BlockHeader
 
     assert.equal(solution.common.hardfork(), Hardfork.Petersburg, 'hardfork did not change')
     assert.equal(solution.common.chainName(), 'mainnet', 'chain name did not change')
 
     const blockMiner = e.getMiner(block)
-    const blockSolution = <Block>await blockMiner.mine(-1)
+    const blockSolution = (await blockMiner.mine(-1)) as Block
 
     assert.equal(blockSolution.common.hardfork(), Hardfork.Petersburg, 'hardfork did not change')
     assert.equal(blockSolution.common.chainName(), 'mainnet', 'chain name did not change')
diff --git a/packages/evm/test/eips/eof-header-validation.spec.ts b/packages/evm/test/eips/eof-header-validation.spec.ts
@@ -41,7 +41,7 @@ await new Promise<void>((resolve, reject) => {
     }
     const name = path.parse(fileName).name
     describe(`EOF Header validation tests - ${name}`, async () => {
-      const testData = JSON.parse(<string>content)
+      const testData = JSON.parse(content as string)
       const evm = await getEVM()
       for (const key in testData) {
         it(`Test ${key}`, () => {
diff --git a/packages/testdata/package.json b/packages/testdata/package.json
@@ -7,7 +7,10 @@
   "module": "dist/esm/index.js",
   "exports": {
     ".": {
-      "import": "./dist/esm/index.js",
+      "import": {
+        "typescript": "./src/index.ts",
+        "default": "./dist/esm/index.js"
+      },
       "require": "./dist/cjs/index.js"
     }
   },
diff --git a/packages/tx/test/eip1559.spec.ts b/packages/tx/test/eip1559.spec.ts
@@ -55,7 +55,7 @@ describe('[FeeMarket1559Tx]', () => {
         if (
           !(
             value === 'chainId' &&
-            ((typeof testCase === 'number' && isNaN(<number>testCase)) || testCase === false)
+            ((typeof testCase === 'number' && isNaN(testCase)) || testCase === false)
           )
         ) {
           txData[value] = testCase
diff --git a/packages/tx/test/typedTxsAndEIP2930.spec.ts b/packages/tx/test/typedTxsAndEIP2930.spec.ts
@@ -149,7 +149,7 @@ describe('[AccessList2930Tx / FeeMarket1559Tx] -> EIP-2930 Compatibility', () =>
         if (
           !(
             value === 'chainId' &&
-            ((typeof testCase === 'number' && isNaN(<number>testCase)) || testCase === false)
+            ((typeof testCase === 'number' && isNaN(testCase)) || testCase === false)
           )
         ) {
           txData[value] = testCase
diff --git a/packages/util/test/account.spec.ts b/packages/util/test/account.spec.ts
@@ -323,7 +323,7 @@ describe('Utility Functions', () => {
     pubKey =
       '0x3a443d8381a6798a70c6ff9304bdc8cb0163c23211d11628fae52ef9e0dca11a001cf066d56a8156fc201cd5df8a36ef694eecd258903fca7086c1fae7441e1d' as any
     try {
-      isValidPublic((<unknown>pubKey) as Uint8Array)
+      isValidPublic(pubKey as Uint8Array)
     } catch (err: any) {
       assert.isTrue(
         err.message.includes('This method only supports Uint8Array'),
@@ -372,7 +372,7 @@ describe('Utility Functions', () => {
 
     assert.throws(
       function () {
-        importPublic((<unknown>pubKey) as Uint8Array)
+        importPublic(pubKey as unknown as Uint8Array)
       },
       undefined,
       undefined,
@@ -462,7 +462,7 @@ describe('Utility Functions', () => {
 
     privateKey = '0xea54bdc52d163f88c93ab0615782cf718a2efb9e51a7989aab1b08067e9c1c5f' as any
     try {
-      privateToPublic((<unknown>privateKey) as Uint8Array)
+      privateToPublic(privateKey as Uint8Array)
     } catch (err: any) {
       assert.isTrue(
         err.message.includes('This method only supports Uint8Array'),
@@ -563,7 +563,7 @@ describe('Utility Functions', () => {
     assert.throws(
       function () {
         generateAddress2(
-          (<unknown>address) as Uint8Array,
+          address as unknown as Uint8Array,
           hexToBytes(salt as PrefixedHexString),
           hexToBytes(initCode as PrefixedHexString),
         )
@@ -577,7 +577,7 @@ describe('Utility Functions', () => {
       function () {
         generateAddress2(
           hexToBytes(address as PrefixedHexString),
-          (<unknown>salt) as Uint8Array,
+          salt as unknown as Uint8Array,
           hexToBytes(initCode as PrefixedHexString),
         )
       },
@@ -591,7 +591,7 @@ describe('Utility Functions', () => {
         generateAddress2(
           hexToBytes(address as PrefixedHexString),
           hexToBytes(salt as PrefixedHexString),
-          (<unknown>initCode) as Uint8Array,
+          initCode as unknown as Uint8Array,
         )
       },
       undefined,
diff --git a/packages/util/test/bytes.spec.ts b/packages/util/test/bytes.spec.ts
@@ -77,7 +77,7 @@ describe('unpadArray', () => {
   })
   it('should throw if input is not an Array', () => {
     assert.throws(function () {
-      unpadArray((<unknown>toBytes([0, 0, 0, 1])) as number[])
+      unpadArray(toBytes([0, 0, 0, 1]) as unknown as number[])
     })
   })
 })
diff --git a/packages/vm/src/runBlock.ts b/packages/vm/src/runBlock.ts
@@ -393,15 +393,15 @@ export async function runBlock(vm: VM, opts: RunBlockOpts): Promise<RunBlockResu
   if (enableProfiler) {
     // eslint-disable-next-line no-console
     console.timeEnd(entireBlockLabel)
-    const logs = (<EVM>vm.evm).getPerformanceLogs()
+    const logs = (vm.evm as EVM).getPerformanceLogs()
     if (logs.precompiles.length === 0 && logs.opcodes.length === 0) {
       // eslint-disable-next-line no-console
       console.log('No block txs with precompile or opcode execution.')
     }
 
     emitEVMProfile(logs.precompiles, 'Precompile performance')
     emitEVMProfile(logs.opcodes, 'Opcodes performance')
-    ;(<EVM>vm.evm).clearPerformanceLogs()
+    ;(vm.evm as EVM).clearPerformanceLogs()
   }
 
   return results
diff --git a/packages/vm/src/runTx.ts b/packages/vm/src/runTx.ts
@@ -149,7 +149,7 @@ export async function runTx(vm: VM, opts: RunTxOpts): Promise<RunTxResult> {
       throw EthereumJSErrorWithoutCode(msg)
     }
 
-    const castedTx = <AccessList2930Tx>opts.tx
+    const castedTx = opts.tx as AccessList2930Tx
 
     for (const accessListItem of castedTx.accessList) {
       const [addressBytes, slotBytesList] = accessListItem
@@ -183,14 +183,14 @@ export async function runTx(vm: VM, opts: RunTxOpts): Promise<RunTxResult> {
     if (enableProfiler) {
       // eslint-disable-next-line no-console
       console.timeEnd(entireTxLabel)
-      const logs = (<EVM>vm.evm).getPerformanceLogs()
+      const logs = (vm.evm as EVM).getPerformanceLogs()
       if (logs.precompiles.length === 0 && logs.opcodes.length === 0) {
         // eslint-disable-next-line no-console
         console.log('No precompile or opcode execution.')
       }
       emitEVMProfile(logs.precompiles, 'Precompile performance')
       emitEVMProfile(logs.opcodes, 'Opcodes performance')
-      ;(<EVM>vm.evm).clearPerformanceLogs()
+      ;(vm.evm as EVM).clearPerformanceLogs()
     }
   }
 }
@@ -449,10 +449,10 @@ async function _runTx(vm: VM, opts: RunTxOpts): Promise<RunTxResult> {
     gasPrice = inclusionFeePerGas + baseFee
   } else {
     // Have to cast as legacy tx since EIP1559 tx does not have gas price
-    gasPrice = (<LegacyTx>tx).gasPrice
+    gasPrice = (tx as LegacyTx).gasPrice
     if (vm.common.isActivatedEIP(1559)) {
       const baseFee = block?.header.baseFeePerGas ?? DEFAULT_HEADER.baseFeePerGas!
-      inclusionFeePerGas = (<LegacyTx>tx).gasPrice - baseFee
+      inclusionFeePerGas = (tx as LegacyTx).gasPrice - baseFee
     }
   }
 
@@ -476,7 +476,7 @@ async function _runTx(vm: VM, opts: RunTxOpts): Promise<RunTxResult> {
 
   if (tx.supports(Capability.EIP7702EOACode)) {
     // Add contract code for authority tuples provided by EIP 7702 tx
-    const authorizationList = (<EIP7702CompatibleTx>tx).authorizationList
+    const authorizationList = (tx as EIP7702CompatibleTx).authorizationList
     for (let i = 0; i < authorizationList.length; i++) {
       // Authority tuple validation
       const data = authorizationList[i]
diff --git a/packages/vm/test/api/muirGlacier/index.spec.ts b/packages/vm/test/api/muirGlacier/index.spec.ts
@@ -2,13 +2,18 @@ import { Common, Hardfork, Mainnet } from '@ethereumjs/common'
 import { KECCAK256_RLP } from '@ethereumjs/util'
 import { assert, describe, it } from 'vitest'
 
+import type { MerkleStateManager } from '@ethereumjs/statemanager'
 import { createVM } from '../../../src/index.ts'
 
 describe('General MuirGlacier VM tests', () => {
   it('should accept muirGlacier hardfork option for supported chains', async () => {
     const common = new Common({ chain: Mainnet, hardfork: Hardfork.MuirGlacier })
     const vm = await createVM({ common })
     assert.isDefined(vm.stateManager)
-    assert.deepEqual((<any>vm.stateManager)._trie.root(), KECCAK256_RLP, 'it has default trie')
+    assert.deepEqual(
+      (vm.stateManager as MerkleStateManager)['_trie'].root(),
+      KECCAK256_RLP,
+      'it has default trie',
+    )
   })
 })
diff --git a/packages/vm/test/api/runTx.spec.ts b/packages/vm/test/api/runTx.spec.ts
@@ -598,7 +598,7 @@ describe('runTx() -> API return values', () => {
       } else {
         assert.equal(
           res.amountSpent,
-          res.totalGasSpent * (<LegacyTx>tx).gasPrice,
+          res.totalGasSpent * (tx as LegacyTx).gasPrice,
           `runTx result -> amountSpent -> gasUsed * gasPrice (${txType.name})`,
         )
       }
diff --git a/packages/vm/test/t8n/stateTracker.ts b/packages/vm/test/t8n/stateTracker.ts
@@ -48,7 +48,7 @@ export class StateTracker {
     vm.stateManager.putStorage = async function (...args: [Address, Uint8Array, Uint8Array]) {
       const address = args[0]
       const key = args[1]
-      self['addStorage'](address.toString(), <PrefixedHexString>bytesToHex(key))
+      self['addStorage'](address.toString(), bytesToHex(key))
       return originalPutStorage.apply(this, args)
     }
   }
@@ -90,7 +90,7 @@ export class StateTracker {
       outputAlloc[addressString].storage = outputAlloc[addressString].storage ?? {}
 
       for (const key of storage) {
-        const keyBytes = hexToBytes(<PrefixedHexString>key)
+        const keyBytes = hexToBytes(key)
         let storageKeyTrimmed = bytesToHex(unpadBytes(keyBytes))
         if (storageKeyTrimmed === '0x') {
           storageKeyTrimmed = '0x00'
diff --git a/packages/vm/test/t8n/t8ntool.ts b/packages/vm/test/t8n/t8ntool.ts
@@ -43,7 +43,7 @@ function getBlockchain(inputEnv: T8NEnv) {
       if (Number(key) === number) {
         return {
           hash() {
-            return hexToBytes(<PrefixedHexString>inputEnv.blockHashes[key])
+            return hexToBytes(inputEnv.blockHashes[key])
           },
         }
       }
@@ -154,7 +154,7 @@ export class TransitionTool {
     const parentBlock = createBlock({ header: parentBlockHeader }, { common: this.common })
 
     const headerData = block.header.toJSON()
-    headerData.difficulty = <PrefixedHexString>this.inputEnv.parentDifficulty
+    headerData.difficulty = this.inputEnv.parentDifficulty as PrefixedHexString
 
     const builder = await buildBlock(this.vm, {
       parentBlock,
diff --git a/packages/vm/test/util.ts b/packages/vm/test/util.ts

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ await new Promise<void>((resolve, reject) => {`
`41`	`41`	`}`
`42`	`42`	`const name = path.parse(fileName).name`
`43`	`43`	describe(`EOF Header validation tests - ${name}`, async () => {
`44`		`- const testData = JSON.parse(<string>content)`
	`44`	`+ const testData = JSON.parse(content as string)`
`45`	`45`	`const evm = await getEVM()`
`46`	`46`	`for (const key in testData) {`
`47`	`47`	it(`Test ${key}`, () => {