No more unerasable syntax (#3972)

* Remove all angle bracket type casting

* Add new erasableSyntax job

* rename ci job

* add push trigger

* add keys for `push`

* remove angle brackets

* skip build step

* try to execute a block

* Fix script

* AI thinks this is more clever

* redo script

* Remove unerasable syntax

* fix CI and testdata exports map

* clean up ci job

* Update .github/workflows/noCompile.yml

Co-authored-by: Gabriel Rocheleau <[email protected]>

---------

Co-authored-by: Holger Drewes <[email protected]>
Co-authored-by: Gabriel Rocheleau <[email protected]>

Author: 3 people

.github/workflows/noCompile.yml

@@ -0,0 +1,49 @@
+name: NoCompile
+on:
+  workflow_call:
+    inputs:
+      dep-cache-key:
+        required: true
+        type: string
+  workflow_dispatch:
+    inputs:
+      dep-cache-key:
+        required: false
+        default: 'none'
+  push:
+    branches:
+      - master
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}-noCompile
+  cancel-in-progress: true
+
+jobs:
+  test-nocompile:
+    runs-on: ubuntu-latest
+    # Set default values for cache keys when triggered by push
+    env:
+      DEP_CACHE_KEY: ${{ github.event_name == 'push' && 'none' || inputs.dep-cache-key }}
+    
+    steps:
+      # We restore the code/deps from cache if triggered from workflow_call (i.e. have valid cache key)
+      - if: env.DEP_CACHE_KEY != 'none' 
+        uses: actions/cache/restore@v4
+        id: dep-cache
+        with:
+          path: ${{github.workspace}}
+          key: ${{ env.DEP_CACHE_KEY }}
+  
+      - name: Use Node.js 23
+        uses: actions/setup-node@v4
+        with:
+          node-version: 23
+          cache: 'npm'
+
+      - name: Install Dependencies (if not restored from cache)
+        if: steps.dep-cache.outputs.cache-hit != 'true'
+        run: npm ci --ignore-scripts  
+        working-directory: ${{ github.workspace }}
+    
+      - run: node --conditions=typescript --experimental-strip-types examples/inlineClient.ts
+        working-directory: ${{ github.workspace }}/packages/client

packages/client/examples/inlineClient.ts

@@ -0,0 +1,19 @@
+import { createCommonFromGethGenesis } from '@ethereumjs/common'
+import { eip4844GethGenesis } from '@ethereumjs/testdata'
+import { Config } from '../src/config.ts'
+import { createInlineClient } from '../src/util/inclineClient.ts'
+
+const main = async () => {
+  const client = await createInlineClient(
+    new Config({}),
+    createCommonFromGethGenesis(eip4844GethGenesis, {}),
+    {},
+    undefined,
+    true,
+  )
+  await client.start()
+  await client.stop()
+  process.exit(0)
+}
+
+main()

packages/client/src/net/peer/peer.ts

@@ -170,12 +170,12 @@ export abstract class Peer extends EventEmitter {
 
       await bound!.handshake(sender)
 
-      this.eth = <BoundEthProtocol>bound
+      this.eth = bound as BoundEthProtocol
     } else if (protocol.name === 'snap') {
       bound = new BoundSnapProtocol(boundOpts)
       if (sender.status === undefined) throw Error('Snap can only be bound on handshaked peer')
 
-      this.snap = <BoundSnapProtocol>bound
+      this.snap = bound as BoundSnapProtocol
     } else {
       throw EthereumJSErrorWithoutCode(`addProtocol: ${protocol.name} protocol not supported`)
     }

packages/client/src/sync/fetcher/fetcher.ts

@@ -483,7 +483,7 @@ export abstract class Fetcher<JobTask, JobResult, StorageItem> extends Readable
         many: { chunk: Job<JobTask, JobResult, StorageItem>; encoding: string }[],
         cb: Function,
       ) => {
-        const items = (<Job<JobTask, JobResult, StorageItem>[]>[]).concat(
+        const items = ([] as Job<JobTask, JobResult, StorageItem>[]).concat(
           ...many.map(
             (x: { chunk: Job<JobTask, JobResult, StorageItem>; encoding: string }) => x.chunk,
           ),

packages/client/test/sync/beaconsync.spec.ts

@@ -120,7 +120,7 @@ describe('[BeaconSynchronizer]', async () => {
     /// @ts-expect-error -- Assigning simpler config for testing
     sync.pool = { peers }
     sync['forceSync'] = true
-    assert.equal(await sync.best(), <any>peers[1], 'found best')
+    assert.equal(await sync.best(), peers[1] as any, 'found best')
     await sync.stop()
     await sync.close()
   })

packages/client/test/sync/fetcher/fetcher.spec.ts

@@ -76,7 +76,7 @@ describe('should handle expiration', async () => {
     })
 
     fetcher['in'].insert(job as any)
-    ;(<any>fetcher)['_readableState'] = []
+    ;(fetcher as any)['_readableState'] = []
     fetcher['running'] = true
     fetcher['total'] = 10
     fetcher.next()

packages/ethash/src/index.ts

@@ -93,12 +93,12 @@ export class Miner {
 
     if (solution) {
       if (this.block) {
-        const data = <BlockData>this.block.toJSON()
+        const data = this.block.toJSON() as BlockData
         data.header!.mixHash = solution.mixHash
         data.header!.nonce = solution.nonce
         return createBlock(data, { common: this.block.common })
       } else {
-        const data = <HeaderData>this.blockHeader.toJSON()
+        const data = this.blockHeader.toJSON() as HeaderData
         data.mixHash = solution.mixHash
         data.nonce = solution.nonce
         return createBlockHeader(data, { common: this.blockHeader.common })

packages/ethash/test/miner.spec.ts

@@ -65,15 +65,15 @@ describe('Miner', () => {
       { common },
     )
     const miner = e.getMiner(block.header)
-    const solution = <BlockHeader>await miner.mine(-1)
+    const solution = (await miner.mine(-1)) as BlockHeader
 
     assert.isTrue(
       await e.verifyPOW(createBlock({ header: solution.toJSON() }, { common })),
       'successfully mined block',
     )
 
     const blockMiner = e.getMiner(block)
-    const blockSolution = <Block>await blockMiner.mine(-1)
+    const blockSolution = (await blockMiner.mine(-1)) as Block
 
     assert.isTrue(await e.verifyPOW(blockSolution))
   }, 60000)
@@ -129,13 +129,13 @@ describe('Miner', () => {
     )
 
     const miner = e.getMiner(block.header)
-    const solution = <BlockHeader>await miner.mine(-1)
+    const solution = (await miner.mine(-1)) as BlockHeader
 
     assert.equal(solution.common.hardfork(), Hardfork.Petersburg, 'hardfork did not change')
     assert.equal(solution.common.chainName(), 'mainnet', 'chain name did not change')
 
     const blockMiner = e.getMiner(block)
-    const blockSolution = <Block>await blockMiner.mine(-1)
+    const blockSolution = (await blockMiner.mine(-1)) as Block
 
     assert.equal(blockSolution.common.hardfork(), Hardfork.Petersburg, 'hardfork did not change')
     assert.equal(blockSolution.common.chainName(), 'mainnet', 'chain name did not change')

packages/evm/test/eips/eof-header-validation.spec.ts

@@ -41,7 +41,7 @@ await new Promise<void>((resolve, reject) => {
     }
     const name = path.parse(fileName).name
     describe(`EOF Header validation tests - ${name}`, async () => {
-      const testData = JSON.parse(<string>content)
+      const testData = JSON.parse(content as string)
       const evm = await getEVM()
       for (const key in testData) {
         it(`Test ${key}`, () => {

packages/testdata/package.json

@@ -7,7 +7,10 @@
   "module": "dist/esm/index.js",
   "exports": {
     ".": {
-      "import": "./dist/esm/index.js",
+      "import": {
+        "typescript": "./src/index.ts",
+        "default": "./dist/esm/index.js"
+      },
       "require": "./dist/cjs/index.js"
     }
   },