tx: moved isSigned() method to BaseTransaction

Author: holgerd77

packages/tx/src/baseTransaction.ts

@@ -148,7 +148,10 @@ export abstract class BaseTransaction<TransactionObject> {
 
   abstract getMessageToVerifySignature(): Buffer
 
-  abstract isSigned(): boolean
+  public isSigned(): boolean {
+    const { v, r, s } = this
+    return !!v && !!r && !!s
+  }
 
   /**
    * Determines if the signature is valid

packages/tx/src/eip2930Transaction.ts

@@ -285,11 +285,6 @@ export default class AccessListEIP2930Transaction extends BaseTransaction<Access
     return this.getMessageToSign()
   }
 
-  public isSigned(): boolean {
-    const { yParity, r, s } = this
-    return yParity !== undefined && !!r && !!s
-  }
-
   public getSenderPublicKey(): Buffer {
     if (!this.isSigned()) {
       throw new Error('Cannot call this method if transaction is not signed')

packages/tx/src/legacyTransaction.ts

@@ -22,7 +22,6 @@ const N_DIV_2 = new BN('7fffffffffffffffffffffffffffffff5d576e7357a4501ddfe92f46
  * An Ethereum transaction.
  */
 export default class Transaction extends BaseTransaction<Transaction> {
-
   get transactionType(): number {
     return 0
   }
@@ -171,11 +170,6 @@ export default class Transaction extends BaseTransaction<Transaction> {
     return this._getMessageToSign(withEIP155)
   }
 
-  public isSigned(): boolean {
-    const { v, r, s } = this
-    return !!v && !!r && !!s
-  }
-
   /**
    * Returns the public key of the sender
    */

packages/tx/src/transactionFactory.ts

@@ -15,14 +15,20 @@ export default class TransactionFactory {
    * @param txData - The transaction data. The `type` field will determine which transaction type is returned (if undefined, create a Transaction)
    * @param txOptions - Options to pass on to the constructor of the transaction
    */
-  public static fromTxData(txData: TxData | AccessListEIP2930TxData, txOptions: TxOptions = {}): TypedTransaction {
+  public static fromTxData(
+    txData: TxData | AccessListEIP2930TxData,
+    txOptions: TxOptions = {}
+  ): TypedTransaction {
     const common = txOptions.common ?? DEFAULT_COMMON
     if (!('type' in txData) || txData.type === undefined) {
       // Assume Transaction
       return Transaction.fromTxData(<TxData>txData, txOptions)
     } else {
       const txType = new BN(txData.type).toNumber()
-      return TransactionFactory.getTransactionClass(txType, common).fromTxData(<AccessListEIP2930TxData>txData, txOptions)
+      return TransactionFactory.getTransactionClass(txType, common).fromTxData(
+        <AccessListEIP2930TxData>txData,
+        txOptions
+      )
     }
   }
 

packages/tx/src/types.ts

@@ -94,17 +94,17 @@ export type TxData = {
   /**
    * EC recovery ID.
    */
-   v?: BNLike
-
-   /**
-    * EC signature parameter.
-    */
-   r?: BNLike
- 
-   /**
-    * EC signature parameter.
-    */
-   s?: BNLike
+  v?: BNLike
+
+  /**
+   * EC signature parameter.
+   */
+  r?: BNLike
+
+  /**
+   * EC signature parameter.
+   */
+  s?: BNLike
 }
 
 /**