fix unhandled promise warning (#1006)

Author: ryanio

packages/client/lib/net/protocol/boundprotocol.ts

@@ -167,7 +167,10 @@ export class BoundProtocol extends EventEmitter {
     for (const message of messages) {
       const name = message.name as string
       const camel = name[0].toLowerCase() + name.slice(1)
-      ;(this as any)[camel] = async (args: any[]) => this.request(name, args)
+      ;(this as any)[camel] = async (args: any[]) =>
+        this.request(name, args).catch((error: Error) => {
+          this.emit('error', error)
+        })
     }
   }
 }

packages/client/lib/sync/fullsync.ts

@@ -73,11 +73,11 @@ export class FullSynchronizer extends Synchronizer {
    * @return {Promise} Resolves with header
    */
   async latest(peer: Peer) {
-    const headers = await peer.eth!.getBlockHeaders({
+    const headers = await peer.eth?.getBlockHeaders({
       block: peer.eth!.status.bestHash,
       max: 1,
     })
-    return headers[0]
+    return headers?.[0]
   }
 
   /**
@@ -88,8 +88,9 @@ export class FullSynchronizer extends Synchronizer {
   async syncWithPeer(peer?: Peer): Promise<boolean> {
     if (!peer) return false
     const latest = await this.latest(peer)
+    if (!latest) return false
     const height = new BN(latest.number)
-    const first = ((this.chain.blocks as any).height as BN).addn(1)
+    const first = this.chain.blocks.height.addn(1)
     const count = height.sub(first).addn(1)
     if (count.lten(0)) return false
 

packages/client/test/sync/fullsync.spec.ts

@@ -76,7 +76,7 @@ tape('[FullSynchronizer]', async (t) => {
     const headers = [{ number: 5 }]
     td.when(peer.eth.getBlockHeaders({ block: 'hash', max: 1 })).thenResolve(headers)
     const latest = await sync.latest(peer as any)
-    t.equals(new BN(latest.number).toNumber(), 5, 'got height')
+    t.equals(new BN(latest!.number).toNumber(), 5, 'got height')
     t.end()
   })