client: add dev param to start devnet with miner (#1492)

* client: add dev param to start ephemeral devnet with miner
Co-authored-by: Ryan Ghods <[email protected]>

Author: acolytec3

package-lock.json

@@ -1,4 +1,4 @@
-import Common, { Chain, ConsensusAlgorithm, ConsensusType, Hardfork } from '@ethereumjs/common'
+import Common, { Chain, ConsensusAlgorithm, ConsensusType } from '@ethereumjs/common'
 import {
   Address,
   BN,
@@ -210,12 +210,11 @@ export class BlockHeader {
     if (options.common) {
       this._common = options.common.copy()
     } else {
-      const chain = Chain.Mainnet // default
+      this._common = new Common({
+        chain: Chain.Mainnet, // default
+      })
       if (options.initWithGenesisHeader) {
-        this._common = new Common({ chain, hardfork: Hardfork.Chainstart })
-      } else {
-        // This initializes on the Common default hardfork
-        this._common = new Common({ chain })
+        this._common.setHardforkByBlockNumber(0)
       }
     }
 
@@ -227,7 +226,7 @@ export class BlockHeader {
 
     const hardforkByBlockNumber = options.hardforkByBlockNumber ?? false
     if (hardforkByBlockNumber || options.hardforkByTD) {
-      this._common.setHardforkByBlockNumber(number.toNumber(), options.hardforkByTD)
+      this._common.setHardforkByBlockNumber(number, options.hardforkByTD)
     }
 
     if (this._common.isActivatedEIP(1559)) {

packages/block/src/header.ts

@@ -335,7 +335,7 @@ export default class Blockchain implements BlockchainInterface {
 
     if (!genesisBlock) {
       const common = this._common.copy()
-      common.setHardfork(Hardfork.Chainstart)
+      common.setHardforkByBlockNumber(0)
       genesisBlock = Block.genesis({}, { common })
     }
 
@@ -1470,14 +1470,14 @@ export default class Blockchain implements BlockchainInterface {
       const blockHash = header.hash()
       const blockNumber = header.number
 
-      DBSaveLookups(blockHash, blockNumber).map((op) => {
-        ops.push(op)
-      })
-
       if (blockNumber.isZero()) {
         break
       }
 
+      DBSaveLookups(blockHash, blockNumber).map((op) => {
+        ops.push(op)
+      })
+
       // mark each key `_heads` which is currently set to the hash in the DB as
       // stale to overwrite this later.
       Object.keys(this._heads).forEach((name) => {