client: fix tests

Author: jochem-brouwer

packages/client/test/rpc/blockChainStub.ts

@@ -1,3 +1,5 @@
+import { Block } from '@ethereumjs/block'
+
 export function blockChain(options: any) {
   const block = {
     toJSON: () => ({
@@ -12,5 +14,8 @@ export function blockChain(options: any) {
     getBlock: async function (_data: any) {
       return Promise.resolve(block)
     },
+    getLatestHeader() {
+      return Block.fromBlockData().header
+    },
   }
 }

packages/client/test/sync/fetcher/blockfetcher.spec.ts

@@ -58,7 +58,9 @@ tape('[BlockFetcher]', async (t) => {
       count: new BN(0),
     })
     const blocks = [{ header: { number: 1 } }, { header: { number: 2 } }]
-    t.deepEquals(fetcher.process({ task: { count: 2 } }, { blocks }), blocks, 'got results')
+    //@ts-ignore
+    t.deepEquals(fetcher.process({ task: { count: 2 } }, blocks), blocks, 'got results')
+    //@ts-ignore
     t.notOk(fetcher.process({ task: { count: 2 } }, { blocks: [] }), 'bad results')
     t.end()
   })
@@ -75,7 +77,7 @@ tape('[BlockFetcher]', async (t) => {
       count: new BN(0),
     })
     td.when((fetcher as any).pool.idle(td.matchers.anything())).thenReturn('peer0')
-    t.equals(fetcher.peer(undefined), 'peer0', 'found peer')
+    t.equals(fetcher.peer(), 'peer0', 'found peer')
     t.end()
   })
 

packages/client/test/sync/fetcher/fetcher.spec.ts

@@ -2,16 +2,30 @@ import tape from 'tape-catch'
 import td from 'testdouble'
 import { Config } from '../../../lib/config'
 import { Fetcher } from '../../../lib/sync/fetcher/fetcher'
+import { Job } from '../../../lib/sync/fetcher/types'
+
+class FetcherTest extends Fetcher<any, any, any> {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  process(_job: any, res: any) {
+    return undefined // have to return undefined, otherwise the function return signature is void.
+  }
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  async request(_job: any, peer: any) {
+    return
+  }
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  async store(store: any) {}
+}
 
 tape('[Fetcher]', (t) => {
   t.test('should handle bad result', (t) => {
     t.plan(2)
     const config = new Config({ loglevel: 'error', transports: [] })
-    const fetcher = new Fetcher({ config, pool: td.object() })
+    const fetcher = new FetcherTest({ config, pool: td.object() })
     const job: any = { peer: {}, state: 'active' }
     ;(fetcher as any).running = true
-    fetcher.next = td.func<Fetcher['next']>()
-    fetcher.wait = td.func<Fetcher['wait']>()
+    fetcher.next = td.func<FetcherTest['next']>()
+    fetcher.wait = td.func<FetcherTest['wait']>()
     td.when(fetcher.wait()).thenResolve(undefined)
     fetcher.success(job, undefined)
     t.equals((fetcher as any).in.size(), 1, 'enqueued job')
@@ -21,27 +35,27 @@ tape('[Fetcher]', (t) => {
   t.test('should handle failure', (t) => {
     t.plan(2)
     const config = new Config({ loglevel: 'error', transports: [] })
-    const fetcher = new Fetcher({ config, pool: td.object() })
+    const fetcher = new FetcherTest({ config, pool: td.object() })
     const job = { peer: {}, state: 'active' }
     ;(fetcher as any).running = true
-    fetcher.next = td.func<Fetcher['next']>()
+    fetcher.next = td.func<FetcherTest['next']>()
     fetcher.on('error', (err: Error) => t.equals(err.message, 'err0', 'got error'))
-    fetcher.failure(job, new Error('err0'))
+    fetcher.failure(job as Job<any, any, any>, new Error('err0'))
     t.equals((fetcher as any).in.size(), 1, 'enqueued job')
   })
 
   t.test('should handle expiration', (t) => {
     t.plan(2)
     const config = new Config({ loglevel: 'error', transports: [] })
-    const fetcher = new Fetcher({
+    const fetcher = new FetcherTest({
       config,
       pool: td.object(),
       timeout: 5,
     })
     const job = { index: 0 }
     const peer = { idle: true }
-    fetcher.peer = td.func<Fetcher['peer']>()
-    fetcher.request = td.func<Fetcher['request']>()
+    fetcher.peer = td.func<FetcherTest['peer']>()
+    fetcher.request = td.func<FetcherTest['request']>()
     td.when(fetcher.peer()).thenReturn(peer)
     td.when(fetcher.request(td.matchers.anything(), { idle: false }), { delay: 10 }).thenReject(
       new Error('err0')

packages/client/test/sync/fetcher/headerfetcher.spec.ts

@@ -2,6 +2,7 @@ import { EventEmitter } from 'events'
 import tape from 'tape-catch'
 import td from 'testdouble'
 import { Config } from '../../../lib/config'
+import { BN } from 'ethereumjs-util'
 
 tape('[HeaderFetcher]', async (t) => {
   class PeerPool extends EventEmitter {
@@ -21,11 +22,13 @@ tape('[HeaderFetcher]', async (t) => {
     const fetcher = new HeaderFetcher({ config, pool, flow })
     const headers = [{ number: 1 }, { number: 2 }]
     t.deepEquals(
-      fetcher.process({ task: { count: 2 }, peer: 'peer0' }, { headers, bv: 1 }),
+      //@ts-ignore
+      fetcher.process({ task: { count: 2 }, peer: 'peer0' }, { headers, bv: new BN(1) }),
       headers,
       'got results'
     )
-    t.notOk(fetcher.process({ task: { count: 2 } }, { headers: [] }), 'bad results')
+    //@ts-ignore
+    t.notOk(fetcher.process({ task: { count: 2 } }, { headers: [], bv: new BN(1) }), 'bad results')
     td.verify((fetcher as any).flow.handleReply('peer0', 1))
     t.end()
   })
@@ -35,6 +38,7 @@ tape('[HeaderFetcher]', async (t) => {
     const pool = new PeerPool()
     const fetcher = new HeaderFetcher({ config, pool })
     td.when((fetcher as any).pool.idle(td.matchers.anything())).thenReturn('peer0')
+    //@ts-ignore
     t.equals(fetcher.peer(undefined), 'peer0', 'found peer')
     t.end()
   })

packages/client/test/sync/sync.spec.ts

@@ -3,6 +3,13 @@ import tape from 'tape-catch'
 import td from 'testdouble'
 import { Config } from '../../lib/config'
 import { Chain } from '../../lib/blockchain'
+import { Synchronizer } from '../../lib/sync/sync'
+
+class SynchronizerTest extends Synchronizer {
+  async sync() {
+    return false
+  }
+}
 
 tape('[Synchronizer]', async (t) => {
   class PeerPool extends EventEmitter {
@@ -13,13 +20,11 @@ tape('[Synchronizer]', async (t) => {
   PeerPool.prototype.close = td.func<any>()
   td.replace('../../lib/net/peerpool', { PeerPool })
 
-  const { Synchronizer } = await import('../../lib/sync/sync')
-
   t.test('should sync', async (t) => {
     const config = new Config({ loglevel: 'error', transports: [] })
     const pool = new PeerPool() as any
     const chain = new Chain({ config })
-    const sync = new Synchronizer({ config, pool, chain })
+    const sync = new SynchronizerTest({ config, pool, chain })
     ;(sync as any).sync = td.func()
     td.when((sync as any).sync()).thenResolve(true)
     sync.on('synchronized', async () => {