Fix return value computation

Author: acolytec3

packages/evm/src/precompiles/12-execute.ts

@@ -118,7 +118,7 @@ export async function precompile12(opts: PrecompileInput): Promise<ExecResult> {
     const stem = stateDiff.stem
     await tree.put(stem, suffixes, values)
   }
-  const executionResult = true
+  let executionResult = true
 
   const stateManager = new StatefulVerkleStateManager({ common: opts.common, trie: tree })
   const l2EVM = await createEVM({ stateManager, common: opts.common })
@@ -146,12 +146,12 @@ export async function precompile12(opts: PrecompileInput): Promise<ExecResult> {
 
   if (computedGasUsed !== executeGasUsed) {
     opts._debug?.(`${pName} gas used mismatch: ${computedGasUsed} !== ${executeGasUsed}`)
-    return EvmErrorResult(new EvmError(ERROR.REVERT), opts.gasLimit)
+    executionResult = false
   }
 
   if (!equalsBytes(postStateRoot, tree.root())) {
     opts._debug?.(`${pName} post state root mismatch`)
-    return EvmErrorResult(new EvmError(ERROR.REVERT), opts.gasLimit)
+    executionResult = false
   }
 
   opts._debug?.(`${pName} trace executed successfully=${executionResult}`)

packages/evm/test/precompiles/12-execute.spec.ts

@@ -50,6 +50,7 @@ describe('Precompiles: EXECUTE', () => {
     const tree = await createVerkleTree({ verkleCrypto: verkle })
     const stateManager = new StatefulVerkleStateManager({ common, trie: tree })
     await stateManager.putAccount(address, account)
+
     const preStateRoot = tree.root()
     const evm = await createEVM({ stateManager, common })
 
@@ -83,8 +84,8 @@ describe('Precompiles: EXECUTE', () => {
     }
     const traceBytes = traceContainer.encode(trace)
 
-    // We use the hash as a reference to the trace.  This should be replaced with a proper blob commitment (or versionedHash)
-    // and the data should be stored as a proper Ethereum blob
+    // We use the sha256 hash of the serialized trace as a reference.  This is standing in for the versionedHash that we should use
+    // once we have the trace properly converted to an Ethereum blob.
     const hash = bytesToHex(sha256(traceBytes))
     evm['executionBlobs'].set(hash, traceBytes)