monorepo: misc type improvements (#3960)

* monorepo: remove some anys

* monorepo: improve types and remove some anys

* monorepo: fix more <any> typecastings

* monorepo: more fixes

* evm: fix opcode type issues with typeguard

* chore: fix formatting

* monorepo: fix types throughout

* monorepo: more type fixes

* evm: remove unnecssary update

* format: spellcheck

* fix: attempt to fix

* Update packages/client/bin/utils.ts

Co-authored-by: Scorbajio <[email protected]>

* refactor: address review and small improvements2

---------

Co-authored-by: Jochem Brouwer <[email protected]>
Co-authored-by: Scorbajio <[email protected]>

Author: 3 people

packages/binarytree/src/binaryTree.ts

@@ -65,7 +65,7 @@ export class BinaryTree {
     this._root = this.EMPTY_TREE_ROOT
 
     if (opts?.root) {
-      this.root(opts.root as any)
+      this.root(opts.root)
     }
 
     this.DEBUG =

packages/block/test/block.spec.ts

@@ -165,7 +165,8 @@ describe('[Block]: block functions', () => {
     const common = new Common({ chain: Mainnet, hardfork: Hardfork.London })
     const block = createBlockFromRLP(blockRlp, { common, freeze: false })
     await testTransactionValidation(block)
-    ;(block.header as any).transactionsTrie = new Uint8Array(32)
+    // @ts-expect-error -- Assigning a read-only property
+    block.header.transactionsTrie = new Uint8Array(32)
     try {
       await block.validateData()
       assert.fail('should throw')
@@ -205,7 +206,8 @@ describe('[Block]: block functions', () => {
     const blockRlp = hexToBytes(testdataPreLondonData.blocks[0].rlp as PrefixedHexString)
     const block = createBlockFromRLP(blockRlp, { common, freeze: false })
     await testTransactionValidation(block)
-    ;(block.transactions[0] as any).gasPrice = BigInt(0)
+    // @ts-expect-error -- Assigning to read-only property
+    block.transactions[0].gasPrice = BigInt(0)
     const result = block.getTransactionsValidationErrors()
     assert.isTrue(
       result[0].includes('tx unable to pay base fee (non EIP-1559 tx)'),
@@ -218,7 +220,8 @@ describe('[Block]: block functions', () => {
     const blockRlp = hexToBytes(testdataPreLondon2Data.blocks[2].rlp as PrefixedHexString)
     const block = createBlockFromRLP(blockRlp, { common, freeze: false })
     assert.equal(block.uncleHashIsValid(), true)
-    ;(block.header as any).uncleHash = new Uint8Array(32)
+    // @ts-expect-error -- Assigning to read-only property
+    block.header.uncleHash = new Uint8Array(32)
     try {
       await block.validateData()
       assert.fail('should throw')

packages/block/test/eip1559block.spec.ts

@@ -94,7 +94,8 @@ describe('EIP1559 tests', () => {
           freeze: false,
         },
       )
-      ;(header as any).baseFeePerGas = undefined
+      // @ts-expect-error -- Assigning to read-only property
+      header.baseFeePerGas = undefined
       await (header as any)._genericFormatValidation()
     } catch (e: any) {
       const expectedError = 'EIP1559 block has no base fee field'

packages/blockchain/test/clique.spec.ts

@@ -218,9 +218,11 @@ describe('Clique: Initialization', () => {
 
   it('should throw if signer in epoch checkpoint is not active', async () => {
     const { blockchain } = await initWithSigners([A])
-    ;(blockchain as any)._validateBlocks = false
+    // @ts-expect-error -- Assign to read-only property
+    blockchain['_validateBlocks'] = false
     // _validateConsensus needs to be true to trigger this test condition
-    ;(blockchain as any)._validateConsensus = true
+    // @ts-expect-error -- Assign to read-only property
+    blockchain['_validateConsensus'] = true
     const number = (COMMON.consensusConfig() as CliqueConfig).epoch
     const unauthorizedSigner = createAddressFromString('0x00a839de7922491683f547a67795204763ff8237')
     const extraData = concatBytes(

packages/client/bin/utils.ts

@@ -551,7 +551,9 @@ async function inputAccounts(args: ClientOpts) {
   })
 
   // Hide key input
-  ;(rl as any).input.on('keypress', function () {
+  // TODO: Investigate why type doesn't match & if this actually works
+  // @ts-expect-error -- Absent from type
+  rl['input'].on('keypress', function () {
     // get the number of characters entered so far:
     const len = (rl as any).line.length
     // move cursor back to the beginning of the input:
@@ -560,7 +562,9 @@ async function inputAccounts(args: ClientOpts) {
     readline.clearLine((rl as any).output, 1)
     // replace the original input with asterisks:
     for (let i = 0; i < len; i++) {
-      ;(rl as any).output.write('*')
+      // TODO: Investigate why type doesn't match & if this actually works
+      // @ts-expect-error -- Absent from type
+      rl['output'].write('*')
     }
   })
 
@@ -579,7 +583,9 @@ async function inputAccounts(args: ClientOpts) {
         const inputKey = (await question(
           `Please enter the 0x-prefixed private key to unlock ${address}:\n`,
         )) as PrefixedHexString
-        ;(rl as any).history = (rl as any).history.slice(1)
+        // TODO: Investigate why type doesn't match & if this actually works
+        // @ts-expect-error -- -- Property not present on type
+        rl['history'] = rl['history'].slice(1)
         const privKey = hexToBytes(inputKey)
         const derivedAddress = createAddressFromPrivateKey(privKey)
         if (address.equals(derivedAddress) === true) {
@@ -720,7 +726,8 @@ export async function generateClientConfig(args: ClientOpts) {
     common = createCommonFromGethGenesis(genesisFile, {
       chain: chainName,
     })
-    ;(common.customCrypto as any) = cryptoFunctions
+    // @ts-expect-error -- Assign to read-only property
+    common.customCrypto = cryptoFunctions
     customGenesisState = parseGethGenesisState(genesisFile)
   }
 

packages/client/src/execution/vmexecution.ts

@@ -112,7 +112,8 @@ export class VMExecution extends Execution {
 
     if (this.config.vm !== undefined) {
       this.vm = this.config.vm
-      ;(this.vm as any).blockchain = this.chain.blockchain
+      // @ts-expect-error -- Assigning to read-only property
+      this.vm.blockchain = this.chain.blockchain
     }
 
     if (this.metaDB) {

packages/client/test/cli/cli.spec.ts

@@ -277,7 +277,9 @@ describe('[CLI]', () => {
         assert.include(message, 'engine', 'engine ws started')
         await wait(600)
         const client = Client.websocket({ url: 'ws://0.0.0.0:' + customPort })
-        ;(client as any).ws.on('open', async function () {
+        // TODO: Investigate why type doesn't match & if this actually works
+        // @ts-expect-error -- Property not present on type
+        client['ws'].on('open', async function () {
           const res = await client.request('engine_exchangeCapabilities', [], 2.0)
           assert.isTrue(res.result.length > 0, 'read from WS RPC on custom address and port')
           child.kill()
@@ -307,7 +309,9 @@ describe('[CLI]', () => {
         // if ws endpoint startup message detected, call ws endpoint with RPC method
         await wait(600)
         const client = Client.websocket({ url: 'ws://0.0.0.0:' + customPort })
-        ;(client as any).ws.on('open', async function () {
+        // TODO: Investigate why type doesn't match & if this actually works
+        // @ts-expect-error -- Property not present on type
+        client['ws'].on('open', async function () {
           const res = await client.request('web3_clientVersion', [], 2.0)
           assert.isTrue(res.result.includes('EthereumJS'), 'read from WS RPC')
           child.kill()

packages/client/test/integration/beaconsync.spec.ts

@@ -5,6 +5,7 @@ import { assert, describe, expect, it, vi } from 'vitest'
 import { Event } from '../../src/types.ts'
 import { postMergeData } from '../testdata/geth-genesis/post-merge.ts'
 
+import type { BeaconSynchronizer } from '../../src/sync/beaconsync.ts'
 import { destroy, setup, wait } from './util.ts'
 
 const common = createCommonFromGethGenesis(postMergeData, { chain: 'post-merge' })
@@ -21,7 +22,7 @@ describe('should sync blocks', async () => {
   const [remoteServer, remoteService] = await setup({ location: '127.0.0.2', height: 20, common })
   const [localServer, localService] = await setup({ location: '127.0.0.1', height: 0, common })
   const next = await remoteService.chain.getCanonicalHeadHeader()
-  ;(localService.synchronizer as any).skeleton.status.progress.subchains = [
+  ;(localService.synchronizer as BeaconSynchronizer).skeleton['status'].progress.subchains = [
     {
       head: BigInt(21),
       tail: BigInt(21),
@@ -73,7 +74,7 @@ describe('should sync with best peer', async () => {
     common,
     minPeers: 2,
   })
-  ;(localService.synchronizer as any).skeleton.status.progress.subchains = [
+  ;(localService.synchronizer as BeaconSynchronizer).skeleton['status'].progress.subchains = [
     {
       head: BigInt(11),
       tail: BigInt(11),

packages/client/test/integration/client.spec.ts

@@ -17,7 +17,8 @@ const config = new Config({
 })
 
 // attach server to centralized event bus
-;(config.server?.config as any).events = config.events
+/// @ts-expect-error -- Overwriting events
+config.server.config.events = config.events
 const client = await EthereumClient.create({ config })
 
 describe('client should start/stop/error', async () => {

packages/client/test/integration/mocks/mockserver.ts

@@ -39,7 +39,9 @@ export class MockServer extends Server {
       transport: this.name,
       url: `mock://${this.location}`,
     })
-    ;(this.server as any).on('connection', async ({ id, stream }: { id: string; stream: any }) => {
+    // TODO: Investigate why type doesn't match & if this actually works
+    /// @ts-expect-error -- on property does not seem to exist?
+    this.server['on']('connection', async ({ id, stream }: { id: string; stream: any }) => {
       await this.connect(id, stream)
     })
     return true