monorepo: reset ethereum-tests to develop

tx: move api test to legacy test

tx: lint

Author: jochem-brouwer

.gitmodules

@@ -1,4 +1,4 @@
 [submodule "ethereum-tests"]
 	path = packages/ethereum-tests
 	url = https://github.com/qbzzt/tests.git
-	branch = eip2930
+	branch = develop

packages/tx/src/legacyTransaction.ts

@@ -7,13 +7,10 @@ import {
   bnToHex,
   bnToRlp,
   ecrecover,
-  ecsign,
   rlp,
   rlphash,
   toBuffer,
   unpadBuffer,
-  publicToAddress,
-  MAX_INTEGER,
 } from 'ethereumjs-util'
 import { TxOptions, TxData, JsonTx } from './types'
 import { BaseTransaction } from './baseTransaction'

packages/tx/src/transactionFactory.ts

@@ -106,7 +106,6 @@ export default class TransactionFactory {
       default:
         throw new Error(`TypedTransaction with ID ${transactionID} unknown`)
     }
-    throw new Error(`TypedTransaction with ID ${transactionID} unknown`)
   }
 
   /**

packages/tx/test/api.spec.ts renamed to packages/tx/test/legacy.spec.ts

@@ -1,11 +1,7 @@
 import Common from '@ethereumjs/common'
 import { BN } from 'ethereumjs-util'
 import tape from 'tape'
-import {
-  EIP2930Transaction,
-  TransactionFactory,
-  LegacyTransaction
-} from '../src'
+import { EIP2930Transaction, TransactionFactory, LegacyTransaction } from '../src'
 
 const EIP2930Common = new Common({
   eips: [2718, 2929, 2930],