cleanup unused dependencies and fix dependency categorization (#4146)

* chore: remove unused @types/core-js dependencies

- Remove @types/core-js from evm and vm packages
- These dependencies are not used anywhere in the codebase

* chore: move test/benchmark-only dependencies to devDependencies

- Move @types/debug from dependencies to devDependencies in evm package
- Reorganize devDependencies alphabetically in tx and vm packages
- These dependencies are only used in tests, benchmarks, or for TypeScript types

* chore: add missing devDependencies for TypeScript types

- Add @types/debug to mpt, blockchain, binarytree, and vm packages
- Add @types/benchmark to rlp package
- These packages use debug/benchmark in source code but were missing type definitions

* commit lockfile

* fix .lastIndex error

---------

Co-authored-by: ScottyPoi <[email protected]>

Author: ScottyPoi

package-lock.json

@@ -61,6 +61,9 @@
     "ethereum-cryptography": "^3.2.0",
     "lru-cache": "11.0.2"
   },
+  "devDependencies": {
+    "@types/debug": "^4.1.12"
+  },
   "engines": {
     "node": ">=18"
   }

packages/binarytree/package.json

@@ -60,7 +60,8 @@
     "lru-cache": "11.0.2"
   },
   "devDependencies": {
-    "@ethereumjs/ethash": "^10.0.0"
+    "@ethereumjs/ethash": "^10.0.0",
+    "@types/debug": "^4.1.12"
   },
   "engines": {
     "node": ">=18"

packages/blockchain/package.json

@@ -59,15 +59,14 @@
     "@ethereumjs/statemanager": "^10.0.0",
     "@ethereumjs/util": "^10.0.0",
     "@noble/curves": "^1.9.0",
-    "@types/debug": "^4.1.12",
     "debug": "^4.4.0",
     "ethereum-cryptography": "^3.2.0",
     "eventemitter3": "^5.0.1"
   },
   "devDependencies": {
     "@paulmillr/trusted-setups": "^0.2.0",
     "@types/benchmark": "^2.1.5",
-    "@types/core-js": "^2.5.8",
+    "@types/debug": "^4.1.12",
     "@types/minimist": "^1.2.5",
     "@types/node-dir": "^0.0.37",
     "benchmark": "^2.1.4",

packages/evm/package.json

@@ -272,11 +272,10 @@ class EOFHeader {
 
   // Returns the code section for a given program counter position
   getSectionFromProgramCounter(programCounter: number) {
-    if (
-      programCounter < 0 ||
-      programCounter >
-        this.codeStartPos[this.codeStartPos.lastIndex] + this.codeSizes[this.codeSizes.lastIndex]
-    ) {
+    const lastIndex = this.codeSizes.length - 1
+    const lastStart = this.getCodePosition(lastIndex)
+    const lastEnd = lastStart + this.codeSizes[lastIndex]
+    if (programCounter < 0 || programCounter > lastEnd) {
       // If code position is outside the beginning or end of the code sections, return 0
       throw EthereumJSErrorWithoutCode('program counter out of bounds')
     }

packages/evm/src/eof/container.ts

@@ -62,6 +62,7 @@
   "devDependencies": {
     "@ethereumjs/genesis": "^10.0.0",
     "@types/benchmark": "^2.1.5",
+    "@types/debug": "^4.1.12",
     "abstract-level": "^3.0.1",
     "level": "^9.0.0",
     "lmdb": "^3.2.6",

packages/mpt/package.json

@@ -65,6 +65,7 @@
     "node": ">=18"
   },
   "devDependencies": {
+    "@types/benchmark": "^2.1.5",
     "benchmark": "^2.1.4"
   }
 }

packages/rlp/package.json

@@ -64,9 +64,9 @@
   },
   "devDependencies": {
     "@ethereumjs/testdata": "1.0.0",
+    "@paulmillr/trusted-setups": "^0.2.0",
     "@types/minimist": "^1.2.5",
     "@types/node-dir": "^0.0.37",
-    "@paulmillr/trusted-setups": "^0.2.0",
     "micro-eth-signer": "^0.15.0",
     "minimist": "^1.2.8",
     "node-dir": "^0.1.17",

packages/tx/package.json

@@ -81,9 +81,10 @@
   "devDependencies": {
     "@ethereumjs/blockchain": "^10.0.0",
     "@ethereumjs/ethash": "^10.0.0",
+    "@ethereumjs/testdata": "1.0.0",
     "@paulmillr/trusted-setups": "^0.2.0",
     "@types/benchmark": "^2.1.5",
-    "@types/core-js": "^2.5.8",
+    "@types/debug": "^4.1.12",
     "@types/minimist": "^1.2.5",
     "@types/node-dir": "^0.0.37",
     "benchmark": "^2.1.4",
@@ -95,8 +96,7 @@
     "nyc": "^17.1.0",
     "solc": "^0.8.28",
     "tape": "^5.9.0",
-    "yargs": "^17.7.2",
-    "@ethereumjs/testdata": "1.0.0"
+    "yargs": "^17.7.2"
   },
   "engines": {
     "node": ">=18"