Fix v,r,s check in fromValuesArray

Author: ryanio

packages/tx/src/transaction.ts

@@ -69,9 +69,9 @@ export default class Transaction {
         to: to && to.length > 0 ? new Address(to) : undefined,
         value: new BN(value),
         data: data ?? emptyBuffer,
-        v: !v?.equals(emptyBuffer) ? new BN(v) : undefined,
-        r: !r?.equals(emptyBuffer) ? new BN(r) : undefined,
-        s: !s?.equals(emptyBuffer) ? new BN(s) : undefined,
+        v: v && !v.equals(emptyBuffer) ? new BN(v) : undefined,
+        r: r && !r.equals(emptyBuffer) ? new BN(r) : undefined,
+        s: s && !s.equals(emptyBuffer) ? new BN(s) : undefined,
       },
       opts
     )

packages/tx/test/api.ts

@@ -380,6 +380,12 @@ tape('[Transaction]: Basic functions', function (t) {
     st.ok(tx.isSigned())
     tx = Transaction.fromRlpSerializedTx(rawSigned)
     st.ok(tx.isSigned())
+
+    const signedValues = (rlp.decode(rawSigned) as any) as Buffer[]
+    tx = Transaction.fromValuesArray(signedValues)
+    st.ok(tx.isSigned())
+    tx = Transaction.fromValuesArray(signedValues.slice(0, 6))
+    st.notOk(tx.isSigned())
     st.end()
   })