client: keep networkId as BN in protocol wrappers to avoid number overflow on large network IDs

holgerd77 · holgerd77 · commit a70677e3342f · 2021-03-05T10:40:08.000+01:00
diff --git a/packages/client/lib/net/protocol/ethprotocol.ts b/packages/client/lib/net/protocol/ethprotocol.ts
@@ -150,7 +150,7 @@ export class EthProtocol extends Protocol {
    */
   decodeStatus(status: any): any {
     return {
-      networkId: bufferToInt(status.networkId),
+      networkId: new BN(status.networkId),
       td: new BN(status.td),
       bestHash: status.bestHash,
       genesisHash: status.genesisHash,
diff --git a/packages/client/lib/net/protocol/lesprotocol.ts b/packages/client/lib/net/protocol/lesprotocol.ts
@@ -202,7 +202,7 @@ export class LesProtocol extends Protocol {
       }
     }
     return {
-      networkId: bufferToInt(status.networkId),
+      networkId: new BN(status.networkId),
       headTd: new BN(status.headTd),
       headHash: status.headHash,
       headNum: new BN(status.headNum),

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ export class LesProtocol extends Protocol {`
`202`	`202`	`}`
`203`	`203`	`}`
`204`	`204`	`return {`
`205`		`- networkId: bufferToInt(status.networkId),`
	`205`	`+ networkId: new BN(status.networkId),`
`206`	`206`	`headTd: new BN(status.headTd),`
`207`	`207`	`headHash: status.headHash,`
`208`	`208`	`headNum: new BN(status.headNum),`