tx: removed eipSupport() function in TransactionFactory (redundant, EIP dependency check is done in Common)

Author: holgerd77

packages/tx/src/transactionFactory.ts

@@ -12,6 +12,7 @@ export default class TransactionFactory {
 
   /**
    * Create a transaction from a `txData` object
+   *
    * @param txData - The transaction data. The `type` field will determine which transaction type is returned (if undefined, create a Transaction)
    * @param txOptions - Options to pass on to the constructor of the transaction
    */
@@ -35,6 +36,7 @@ export default class TransactionFactory {
   /**
    * This method tries to decode `raw` data. It is somewhat equivalent to `fromRlpSerializedTx`.
    * However, it could be that the data is not directly RLP-encoded (it is a Typed Transaction)
+   *
    * @param rawData - The raw data buffer
    * @param txOptions - The transaction options
    */
@@ -55,7 +57,7 @@ export default class TransactionFactory {
           throw new Error(`TypedTransaction with ID ${rawData[0]} unknown`)
       }
 
-      if (!TransactionFactory.eipSupport(common, EIP)) {
+      if (!common.isActivatedEIP(EIP)) {
         throw new Error(
           `Cannot create TypedTransaction with ID ${rawData[0]}: EIP ${EIP} not activated`
         )
@@ -72,6 +74,7 @@ export default class TransactionFactory {
    * A Buffer (a TypedTransaction - encoded as TransactionType || rlp(TransactionPayload))
    * A Buffer[] (Transaction)
    * This method returns the right transaction.
+   *
    * @param rawData - Either a Buffer or a Buffer[]
    * @param txOptions - The transaction options
    */
@@ -89,6 +92,7 @@ export default class TransactionFactory {
   /**
    * This helper method allows one to retrieve the class which matches the transactionID
    * If transactionID is undefined, return the Transaction class.
+   *
    * @param transactionID
    * @param common
    */
@@ -113,16 +117,4 @@ export default class TransactionFactory {
         throw new Error(`TypedTransaction with ID ${transactionID} unknown`)
     }
   }
-
-  /**
-   * Check if a typed transaction eip is supported by common
-   * @param common - The common to use
-   * @param eip - The EIP to check
-   */
-  public static eipSupport(common: Common, eip: number): boolean {
-    if (!common.isActivatedEIP(2718)) {
-      return false
-    }
-    return common.isActivatedEIP(eip)
-  }
 }

packages/tx/test/transactionFactory.spec.ts

@@ -109,12 +109,4 @@ tape('[TransactionFactory]: Basic functions', function (t) {
     st.equals(eip2930Tx.constructor.name, AccessListEIP2930Transaction.name)
     st.end()
   })
-
-  t.test('if eip2718 is not activated, always return that the eip is not activated', function (st) {
-    const newCommon = new Common({ chain: 'mainnet', hardfork: 'istanbul' })
-
-    const eip2930Active = TransactionFactory.eipSupport(newCommon, 2930)
-    st.ok(!eip2930Active)
-    st.end()
-  })
 })