monorepo: type improvements (#3947)

* monorepo: remove some anys

* monorepo: improve types and remove some anys

* monorepo: fix more <any> typecastings

* monorepo: more fixes

* evm: fix opcode type issues with typeguard

* chore: fix formatting

---------

Co-authored-by: Holger Drewes <[email protected]>

Author: gabrocheleau

packages/binarytree/src/db/checkpoint.ts

@@ -188,7 +188,7 @@ export class CheckpointDB implements DB {
     } else {
       const valuePut =
         this.valueEncoding === ValueEncoding.Bytes ? value : bytesToUnprefixedHex(value)
-      await this.db.put(keyHex, <any>valuePut, {
+      await this.db.put(keyHex, valuePut, {
         keyEncoding: KeyEncoding.String,
         valueEncoding: this.valueEncoding,
       })
@@ -254,7 +254,7 @@ export class CheckpointDB implements DB {
         }
         return convertedOp
       })
-      await this.db.batch(<any>convertedOps)
+      await this.db.batch(convertedOps as any)
     }
   }
 

packages/blockchain/src/consensus/clique.ts

@@ -12,6 +12,7 @@ import {
   BIGINT_1,
   BIGINT_2,
   EthereumJSErrorWithoutCode,
+  type NestedUint8Array,
   TypeOutput,
   bigIntToBytes,
   bytesToBigInt,
@@ -556,10 +557,13 @@ export class CliqueConsensus implements Consensus {
   private async getCliqueLatestSignerStates(): Promise<CliqueLatestSignerStates> {
     const signerStates = await this.blockchain!.db.get(CLIQUE_SIGNERS_KEY)
     if (signerStates === undefined) return []
-    const states = RLP.decode(signerStates as Uint8Array) as [Uint8Array, Uint8Array[]]
+    const states = RLP.decode(signerStates as Uint8Array) as NestedUint8Array
     return states.map((state) => {
       const blockNum = bytesToBigInt(state[0] as Uint8Array)
-      const addresses = (<any>state[1]).map((bytes: Uint8Array) => new Address(bytes))
+      const addresses: Address[] = (state[1] as Uint8Array[]).map((bytes: Uint8Array): Address => {
+        const address = new Address(bytes)
+        return address
+      })
       return [blockNum, addresses]
     }) as CliqueLatestSignerStates
   }

packages/blockchain/test/index.spec.ts

@@ -609,8 +609,7 @@ describe('blockchain test', () => {
     const hash = await blockchain.dbManager.numberToHash(BigInt(0))
     assert.deepEqual(genesis.hash(), hash, 'should perform _numberToHash correctly')
 
-    // cast the blockchain as <any> in order to get access to the private getTotalDifficulty
-    const td = await (<any>blockchain).getTotalDifficulty(genesis.hash(), BigInt(0))
+    const td = await blockchain.getTotalDifficulty(genesis.hash(), BigInt(0))
     assert.equal(td, genesis.header.difficulty, 'should perform getTotalDifficulty correctly')
   })
 

packages/client/src/sync/fetcher/accountfetcher.ts

@@ -414,7 +414,7 @@ export class AccountFetcher extends Fetcher<JobTask, AccountData[], AccountData>
             null,
             [],
             [],
-            <any>rangeResult.proof,
+            rangeResult.proof,
           )
           // if proof is false, reject corrupt peer
           if (isMissingRightRange !== false) return undefined

packages/client/src/sync/fetcher/storagefetcher.ts

@@ -282,7 +282,7 @@ export class StorageFetcher extends Fetcher<JobTask, StorageData[][], StorageDat
             null,
             [],
             [],
-            <any>rangeResult.proof,
+            rangeResult.proof,
           )
 
           // if proof is false, reject corrupt peer

packages/client/test/sync/fullsync.spec.ts

@@ -114,7 +114,7 @@ describe('[FullSynchronizer]', async () => {
     ;(sync as any).chain = { blocks: { td: BigInt(1) } }
     ;(sync as any).pool = { peers }
     ;(sync as any).forceSync = true
-    assert.equal(await sync.best(), <any>peers[1], 'found best')
+    assert.equal(await sync.best(), peers[1] as any, 'found best')
     await sync.stop()
     await sync.close()
   })

packages/devp2p/test/dns.spec.ts

@@ -7,7 +7,7 @@ import { testData } from './testdata.ts'
 
 describe('DNS', () => {
   const mockData = testData.dns
-  const mockDns = td.replace<any>('dns')
+  const mockDns = td.replace('dns') as any
 
   let dns: DNS
   function initializeDns() {

packages/devp2p/test/integration/eth-simulator.spec.ts

@@ -231,7 +231,8 @@ describe('ETH simulator tests', () => {
           switch (code) {
             case EthMessageCodes.STATUS:
               protocol.sendStatus(status)
-              assert.throws(() => protocol.sendMessage(<any>0x55, []), /Unknown code 85/)
+              // @ts-expect-error -- Testing unknown code
+              assert.throws(() => protocol.sendMessage(0x55, []), /Unknown code 85/)
               util.destroyRLPXs(rlpxs)
               resolve(undefined)
           }

packages/evm/src/interpreter.ts

@@ -438,7 +438,7 @@ export class Interpreter {
    * Get info for an opcode from EVM's list of opcodes.
    */
   lookupOpInfo(op: number): OpcodeMapEntry {
-    return (<any>this._evm)._opcodeMap[op]
+    return this._evm['_opcodeMap'][op]
   }
 
   async _runStepHook(dynamicFee: bigint, gasLeft: bigint): Promise<void> {

packages/evm/src/opcodes/codes.ts

@@ -6,7 +6,7 @@ import { dynamicGasHandlers } from './gas.ts'
 import { getFullname } from './util.ts'
 
 import type { Common } from '@ethereumjs/common'
-import type { CustomOpcode } from '../types.ts'
+import { type CustomOpcode, isAddOpcode } from '../types.ts'
 import type { OpHandler } from './functions.ts'
 import type { AsyncDynamicGasHandler, SyncDynamicGasHandler } from './gas.ts'
 
@@ -50,7 +50,9 @@ export class Opcode {
 }
 
 export type OpcodeList = Map<number, Opcode>
-type OpcodeEntry = { [key: number]: { name: string; isAsync: boolean; dynamicGas: boolean } }
+type OpcodeEntry = {
+  [key: number]: { name: string; isAsync: boolean; dynamicGas: boolean }
+}
 type OpcodeEntryFee = OpcodeEntry & { [key: number]: { fee: number } }
 
 // Default: sync and no dynamic gas
@@ -447,18 +449,13 @@ export function getOpcodesForHF(common: Common, customOpcodes?: CustomOpcode[]):
 
   if (customOpcodes) {
     for (const _code of customOpcodes) {
-      const code = <any>_code
-      if (code.logicFunction === undefined) {
+      const code = _code
+
+      if (!isAddOpcode(code)) {
         delete opcodeBuilder[code.opcode]
         continue
       }
 
-      // Sanity checks
-      if (code.opcodeName === undefined || code.baseFee === undefined) {
-        throw EthereumJSErrorWithoutCode(
-          `Custom opcode ${code.opcode} does not have the required values: opcodeName and baseFee are required`,
-        )
-      }
       const entry = {
         [code.opcode]: {
           name: code.opcodeName,