remove unpadBuffer from eth_call result

ryanio · holgerd77 · commit fbe7fc973eb8 · 2021-03-09T11:08:51.000+01:00
diff --git a/packages/client/lib/rpc/modules/eth.ts b/packages/client/lib/rpc/modules/eth.ts
@@ -6,7 +6,6 @@ import {
   bufferToHex,
   toBuffer,
   stripHexPrefix,
-  unpadBuffer,
   setLengthLeft,
 } from 'ethereumjs-util'
 import { decode } from 'rlp'
@@ -149,7 +148,7 @@ export class Eth {
     }
 
     const { execResult } = await vm.runTx({ tx })
-    return bufferToHex(unpadBuffer(execResult.returnValue))
+    return bufferToHex(execResult.returnValue)
   }
 
   /**
diff --git a/packages/client/test/rpc/eth/call.spec.ts b/packages/client/test/rpc/eth/call.spec.ts
@@ -66,7 +66,7 @@ tape(`${method}: call with valid arguments`, async (t) => {
   const req = params(method, [{ ...estimateTxData, gas: estimateTxData.gasLimit }, 'latest'])
   const expectRes = (res: any) => {
     const msg = 'should return the correct return value'
-    if (res.body.result === bufferToHex(unpadBuffer(execResult.returnValue))) {
+    if (res.body.result === bufferToHex(execResult.returnValue)) {
       t.pass(msg)
     } else {
       throw new Error(msg)

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ import {`
`6`	`6`	`bufferToHex,`
`7`	`7`	`toBuffer,`
`8`	`8`	`stripHexPrefix,`
`9`		`- unpadBuffer,`
`10`	`9`	`setLengthLeft,`
`11`	`10`	`} from 'ethereumjs-util'`
`12`	`11`	`import { decode } from 'rlp'`
`@@ -149,7 +148,7 @@ export class Eth {`
`149`	`148`	`}`
`150`	`149`
`151`	`150`	`const { execResult } = await vm.runTx({ tx })`
`152`		`- return bufferToHex(unpadBuffer(execResult.returnValue))`
	`151`	`+ return bufferToHex(execResult.returnValue)`
`153`	`152`	`}`
`154`	`153`
`155`	`154`	`/**`