Some BLS Optimizations #4201
Open
Some BLS Optimizations #4201
+10
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
📦 Bundle Size Analysis
Generated by bundle-size workflow |
jochem-brouwer
approved these changes
Nov 27, 2025
Member
jochem-brouwer
left a comment
jochem-brouwer
left a comment
There was a problem hiding this comment.
Looks good!
mulG1 and mulG2 were part of BLS spec in the past but have since been moved in the actual spec (so the forked-in version) to the multi-scalar-multiplication (MSM) precompiles for G1 and G2. Reasoning was that extra precompiles are not necessary.
The modulo check you removed is I think a forgotten one from the past cleanups, so looks good.
Let's lower the bundle size 🎉 👍 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimizations / code deletions I stumbled upon BLS coverage analysis using the official test vectors.
The modulo check was simply redundant.
The mul* methods are not used anymore since it was decided along EIP process to not do explicit mul* precompiles (since implicitly included in msm* if I recall correctly).
Will wait for a review from @jochem-brouwer before merge. Should be save though (all consensus tests passing still).