Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
bytesToBigInt#4202Summary of the decisions and rationale (relevant with regards to our previous discussion on #3180 @jochem-brouwer )
bigIntToBytes(0n)[0].bigIntToUnpaddedByteswhen an empty array is desired.[0]= “the number zero”,[]= “empty/absence”; semantically distinct and encoded differently in RLP.setLengthLefttruncation behaviorallowTruncateoption to opt into truncation.bytesToBigInt([])0n.bigIntToUnpaddedBytes.Runtime type checks
assertIsBytes()helper (checkinginstanceof Uint8Array) and use it inbytesToBigIntand other bytes-accepting functions.Mutation bug in
bytesToBigInt.slice().reverse()instead of.reverse()directly on the input.