-
Notifications
You must be signed in to change notification settings - Fork 25
Move code logic from here to the VM #48
Description
The code logic here is unnecessarily detached from the rest of the VM tester code base and round-trips on changing something here, testing the efforts and then have this working with the VM test runner are extremely and unnecessarily long. Just hanging on this again while examining some failures on older blockchain tests.
I propose that we just move the code logic from here to the VM test runner code base and keep this repository only for updating the submodule respectively keeping the large ethereum/tests submodule code base out of the monorepo.
Then we can easily improve on the code base respectively adopt to our needs, also x-checks while working with the tests if tests are loaded correctly (especially important due to relatively frequent and partly implicit changes on the ethereum/tests folder structure. With keeping the procedure on doing tagged releases here and link to them from the VM package this should be also unproblematic from a stability PoV.
//cc @evertonfraga