Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

Commit 13fb20d

Browse files
committed
Removed provider engine support
1 parent 2121d5a commit 13fb20d

File tree

4 files changed

+7
-45
lines changed

4 files changed

+7
-45
lines changed

README.md

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -82,27 +82,13 @@ Please go to [./docs/classes/ethereumhdkey.md](./docs/classes/ethereumhdkey.md)
8282

8383
## Provider Engine
8484

85-
The Wallet can be easily plugged into [provider-engine](https://github.com/metamask/provider-engine) to provide signing:
85+
Provider Engine is
86+
[not very actively maintained](https://github.com/MetaMask/web3-provider-engine#web3-providerengine)
87+
and support has been removed along `v1.0.0` release, see
88+
issue [#115](https://github.com/ethereumjs/ethereumjs-wallet/issues/115) for context.
8689

87-
Node.js / ES5:
88-
89-
```js
90-
const { WalletSubprovider } = require('ethereumjs-wallet')
91-
92-
<engine>.addProvider(new WalletSubprovider(<wallet instance>))
93-
```
94-
95-
ESM / TypeScript:
96-
97-
```js
98-
import { WalletSubprovider } from 'ethereumjs-wallet'
99-
100-
<engine>.addProvider(new WalletSubprovider(<wallet instance>))
101-
```
102-
103-
Note it only supports the basic wallet. With a HD Wallet, call `getWallet()` first.
104-
105-
Please go to [./docs/classes/walletsubprovider.md](./docs/README.md) for more info.
90+
You can use the the old `src/provider-engine.ts` code (see associated PR) as some boilerplate
91+
for your own integration if needed.
10692

10793
### Remarks about `toV3`
10894

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@
5151
"hdkey": "^1.1.1",
5252
"randombytes": "^2.0.6",
5353
"utf8": "^3.0.0",
54-
"uuid": "^3.3.2",
55-
"web3-provider-engine": "^15.0.7"
54+
"uuid": "^3.3.2"
5655
},
5756
"devDependencies": {
5857
"@ethereumjs/config-nyc": "^1.1.1",

src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as crypto from 'crypto'
22
import * as ethUtil from 'ethereumjs-util'
33

44
export { default as hdkey } from './hdkey'
5-
export { default as WalletSubprovider } from './provider-engine'
65
export { default as thirdparty } from './thirdparty'
76

87
const bs58check = require('bs58check')

src/provider-engine.ts

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)