close policy when closing last claim of expired policy

[rapidddenis]

In closeClaim

gif-contracts/contracts/modules/PolicyController.sol

Line 358 in b58fd27

function closeClaim(bytes32 processId, uint256 claimId)

There is no check to close the corresponding policy if it is expired and have no open claims

[matthiaszimmermann]

very nice analysis and true.

this is in the unclear area of what is good usability for the people implementing products on top of the gif framework and too much hidden magic ;)

would you consider this "just" a usability improvement or can you motivate why this should be classified as a bug?

in any case the current handling is inconsistent with the handling of claims... we do close the claim once all payouts associated with the claims have been processed (ie once the claim amount matches with the paid out amount)

"fixing" this would imply a breaking change in any case.