fix ignition deployment (#364)

Author: doerfli

README.md

@@ -72,6 +72,13 @@ export SKIP_VERIFICATION=true
 hh run scripts/deploy_all.ts
 ```
 
+Deployment via ignition
+
+```bash
+npx hardhat ignition deploy ignition/modules/GifCore.ts
+hh ignition deploy ignition/modules/GifCore.ts
+```
+
 ```bash
 # set appropriate values vor env variables (see below)
 

ignition/modules/GifCore.ts

@@ -15,8 +15,11 @@ export default buildModule("GifCore", (m) => {
         objectTypeLib,
         roleIdLib, 
         secondsLib,
+        selectorLib,
+        selectorSetLib,
         stakeManagerLib,
         stateIdLib,
+        strLib,
         targetManagerLib,
         timestamplib, 
         uFixedLib,
@@ -28,11 +31,17 @@ export default buildModule("GifCore", (m) => {
     const dip = m.contract("Dip", []);
 
     // 2) deploy registry admin
-    const registryAdmin = m.contract("RegistryAdmin", [stakingOwner], 
+    const registryAdmin = m.contract("RegistryAdmin", [], 
         {
             libraries: {
-                TimestampLib: timestamplib,
+                ObjectTypeLib: objectTypeLib,
                 RoleIdLib: roleIdLib,
+                SelectorLib: selectorLib,
+                SelectorSetLib: selectorSetLib,
+                StrLib: strLib,
+                TimestampLib: timestamplib,
+                VersionLib: versionLib,
+                VersionPartLib: versionPartLib,
             },
         }
     );
@@ -54,7 +63,6 @@ export default buildModule("GifCore", (m) => {
         {
             libraries: {
                 NftIdLib: nftIdLib,
-                RoleIdLib: roleIdLib,
                 SecondsLib: secondsLib,
                 TimestampLib: timestamplib,
                 VersionLib: versionLib,
@@ -95,6 +103,7 @@ export default buildModule("GifCore", (m) => {
                 NftIdLib: nftIdLib,
                 ObjectTypeLib: objectTypeLib,
                 StateIdLib: stateIdLib,
+                TargetManagerLib: targetManagerLib,
                 TimestampLib: timestamplib,
                 UFixedLib: uFixedLib,
             },
@@ -133,7 +142,7 @@ export default buildModule("GifCore", (m) => {
     });
 
     // 11) initialize registry admin
-    m.call(registryAdmin, "initialize", [registry, gifAdmin, gifManager], {
+    m.call(registryAdmin, "completeSetup", [registry, gifAdmin, gifManager], {
         after: [stakingLinkToRegisteredNftId]
     });
 

ignition/modules/Libraries.ts

@@ -1,26 +1,31 @@
 import { buildModule } from "@nomicfoundation/hardhat-ignition/modules";
 
 export default buildModule("Libraries", (m) => {
+    const selectorLib = m.library("SelectorLib");
+    const selectorSetLib = m.library("SelectorSetLib");
     const secondsLib = m.library("SecondsLib");
+    const strLib = m.library("StrLib");
     const timestamplib = m.library("TimestampLib", {
         libraries: {
             SecondsLib: secondsLib
         }
     });
     const key32Lib = m.library("Key32Lib");
+    const objectTypeLib = m.library("ObjectTypeLib");
+    const versionLib = m.library("VersionLib");
+    const versionPartLib = m.library("VersionPartLib");
     const roleIdLib = m.library("RoleIdLib", {
         libraries: {
-            Key32Lib: key32Lib
+            Key32Lib: key32Lib,
+            ObjectTypeLib: objectTypeLib,
+            VersionPartLib: versionPartLib,
         },
     });
     const nftIdLib = m.library("NftIdLib", {
         libraries: {
             Key32Lib: key32Lib
         },
     });
-    const objectTypeLib = m.library("ObjectTypeLib");
-    const versionLib = m.library("VersionLib");
-    const versionPartLib = m.library("VersionPartLib");
     const blocknumberLib = m.library("BlocknumberLib");
     const nftIdSetLib = m.library("LibNftIdSet");
     const stateIdLib = m.library("StateIdLib");
@@ -58,7 +63,10 @@ export default buildModule("Libraries", (m) => {
         stateIdLib,
         roleIdLib,
         secondsLib, 
+        selectorLib,
+        selectorSetLib,
         stakeManagerLib,
+        strLib,
         targetManagerLib,
         timestamplib, 
         uFixedLib,

package-lock.json

@@ -81,7 +81,7 @@ export async function deployAndInitializeRegistry(owner: Signer, libraries: Libr
     const { address: registryAdminAddress, contract: registryAdminBaseContract } = await deployContract(
         "RegistryAdmin",
         owner, // GIF_ADMIN_ROLE
-        [owner], 
+        [], 
         {
             libraries: {
                 ObjectTypeLib: libraries.objectTypeLibAddress,